Skip to content

Commit 5f0608c

Browse files
committed
remove unecessary code
1 parent fcb17c1 commit 5f0608c

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

mambular/preprocessing/preprocessor.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,9 @@ def fit(self, X, y=None):
227227
numeric_transformer_steps.append(("scaler", StandardScaler()))
228228

229229
elif self.numerical_preprocessing == "normalization":
230-
numeric_transformer_steps.append(("normalizer", MinMaxScaler()))
230+
numeric_transformer_steps.append(
231+
("normalizer", MinMaxScaler(feature_range=(-1, 1)))
232+
)
231233

232234
elif self.numerical_preprocessing == "quantile":
233235
numeric_transformer_steps.append(
@@ -240,12 +242,15 @@ def fit(self, X, y=None):
240242
)
241243

242244
elif self.numerical_preprocessing == "polynomial":
245+
numeric_transformer_steps.append(("scaler", StandardScaler()))
243246
numeric_transformer_steps.append(
244247
(
245248
"polynomial",
246249
PolynomialFeatures(self.degree, include_bias=False),
247250
)
248251
)
252+
# if self.degree > 10:
253+
# numeric_transformer_steps.append(("normalizer", MinMaxScaler()))
249254

250255
elif self.numerical_preprocessing == "splines":
251256
numeric_transformer_steps.append(
@@ -260,13 +265,9 @@ def fit(self, X, y=None):
260265
)
261266

262267
elif self.numerical_preprocessing == "ple":
263-
numeric_transformer_steps.append(("normalizer", MinMaxScaler()))
264268
numeric_transformer_steps.append(
265-
("ple", PLE(n_bins=self.n_bins, task=self.task))
269+
("normalizer", MinMaxScaler(feature_range=(-1, 1)))
266270
)
267-
268-
elif self.numerical_preprocessing == "ple":
269-
numeric_transformer_steps.append(("normalizer", MinMaxScaler()))
270271
numeric_transformer_steps.append(
271272
("ple", PLE(n_bins=self.n_bins, task=self.task))
272273
)

0 commit comments

Comments
 (0)