Fix #125 by calling Convert-Path for SourceDirectory

Author: Jaykul

Source/ModuleBuilder.psd1

@@ -11,7 +11,7 @@
 
             # Release Notes have to be here, so we can update them
             ReleaseNotes   = '
-            Now with Set/New-Alias support, and sorting of the source files.
+            Fix case sensitivity of defaults for SourceDirectories and PublicFilter
             '
 
             # Tags applied to this module. These help with module discovery in online galleries.

Source/Public/Build-Module.ps1

@@ -96,14 +96,14 @@ function Build-Module {
         # Folders which contain source .ps1 scripts to be concatenated into the module
         # Defaults to Enum, Classes, Private, Public
         [string[]]$SourceDirectories = @(
-            "Enum", "Classes", "Private", "Public"
+            "[Ee]num", "[Cc]lasses", "[Pp]rivate", "[Pp]ublic"
         ),
 
         # A Filter (relative to the module folder) for public functions
         # If non-empty, FunctionsToExport will be set with the file BaseNames of matching files
         # Defaults to Public\*.ps1
         [AllowEmptyString()]
-        [string[]]$PublicFilter = "Public\*.ps1",
+        [string[]]$PublicFilter = "[Pp]ublic/*.ps1",
 
         # A switch that allows you to disable the update of the AliasesToExport
         # By default, (if PublicFilter is not empty, and this is not set)
@@ -206,8 +206,11 @@ function Build-Module {
 
             # SilentlyContinue because there don't *HAVE* to be functions at all
             $AllScripts = @($ModuleInfo.SourceDirectories).ForEach{
-                Get-ChildItem -Path (Join-Path -Path $ModuleInfo.ModuleBase -ChildPath $_) -Filter *.ps1 -Recurse -ErrorAction SilentlyContinue |
-                Sort-Object -Property 'FullName'
+                # By explicitly converting, we support wildcards in the SourceDirectories parameter
+                if ($SourceDirectory = Join-Path -Path $ModuleInfo.ModuleBase -ChildPath $_ | Convert-Path -ErrorAction SilentlyContinue) {
+                    Get-ChildItem -Path $SourceDirectory -Filter *.ps1 -Recurse -ErrorAction SilentlyContinue |
+                        Sort-Object -Property 'FullName'
+                }
             }
 
             # We have to force the Encoding to string because PowerShell Core made up encodings

Tests/Integration/Source1.Tests.ps1

@@ -326,3 +326,16 @@ Describe "Copies additional items specified in CopyPaths" {
         'TestDrive:/output/MyModule/1.0.0/lib/subdir/imaginary2.dll' | Should -FileContentMatch '2'
     }
 }
+
+Describe "Regression test for #125: SourceDirectories supports wildcards" -Tag Integration, Regression {
+    BeforeAll {
+        # [Cc]lasses does not exist, but won't throw an error
+        $Output = Build-Module $PSScriptRoot\Source1\build.psd1 -SourceDirectories "[Cc]lasses", "[Pp]rivate", "[Pp]ublic" -PublicFilter "[Pp]ublic/*.ps1" -Passthru -ErrorAction Stop
+        $Module = [IO.Path]::ChangeExtension($Output.Path, "psm1")
+        $Metadata = Import-Metadata $Output.Path
+    }
+
+    It "Finds the public functions" {
+        $Metadata.FunctionsToExport | Should -Be @("Get-Source", "Set-Source")
+    }
+}

Tests/Public/Build-Module.Tests.ps1

@@ -137,10 +137,10 @@ Describe "Build-Module" {
             }
         }
 
-
-
         Mock Push-Location {}
 
+        # So it doesn't have to exist
+        Mock Convert-Path { $Path }
         Mock Get-ChildItem {
             [IO.FileInfo]"$TestDrive/Output/MyModule/Public/Get-MyInfo.ps1"
         }

Tests/Public/ConvertFrom-SourceLineNumber.Tests.ps1

@@ -12,15 +12,14 @@ Describe "ConvertFrom-SourceLineNumber" {
 
         $global:TestCases = @(
             @{ outputLine = 36; sourceFile = ".${\}Private${\}TestUnExportedAliases.ps1"; sourceLine = 13; Module = $Convert_LineNumber_ModulePath }
-            @{ outputLine = 43; sourceFile = ".${\}Public${\}Get-Source.ps1"; sourceLine = 5; Module = $Convert_LineNumber_ModulePath }
-            @{ outputLine = 50; sourceFile = ".${\}Public${\}Set-Source.ps1"; sourceLine = 3; Module = $Convert_LineNumber_ModulePath }
+            @{ outputLine = 43; sourceFile = ".${\}public${\}Get-Source.ps1"; sourceLine = 5; Module = $Convert_LineNumber_ModulePath }
+            @{ outputLine = 50; sourceFile = ".${\}public${\}Set-Source.ps1"; sourceLine = 3; Module = $Convert_LineNumber_ModulePath }
         )
     }
     AfterAll {
         Pop-Location -StackName ConvertFrom-SourceLineNumber
     }
 
-
     It "Should map line <outputLine> in the Module to line <sourceLine> in the source of <sourceFile>" -TestCases $TestCases {
         param($outputLine, $sourceFile, $sourceLine, $module)