Update ListView API usage and improve marking logic

- Replace deprecated ListView properties with ShowMarks/MarkMultiple and update scrollbar config for Terminal.Gui 2.0.0-beta.11.
- Add bounds checking to IsMarked; remove Length property in favor of MaxItemLength.
- Simplify Enter key handling and ListView.Accepted event logic.
- Use Value instead of CheckedState for "All Properties" checkbox.
- Update launch profile to use -OutputMode: Single.
- Minor: ignore exception variable in TypeGetter.

Author: tig

src/Microsoft.PowerShell.ConsoleGuiTools/GridViewDataSource.cs

@@ -25,10 +25,8 @@ internal sealed class GridViewDataSource : IListDataSource
     /// </summary>
     public int Count => GridViewRowList.Count;
 
-    /// <summary>
-    ///     Gets the number of rows in the data source.
-    /// </summary>
-    public int Length => GridViewRowList.Count;
+    /// <inheritdoc />
+    public int MaxItemLength { get; }
 
     /// <summary>
     ///     Gets or sets a value indicating whether to suspend raising the <see cref="CollectionChanged" /> event.
@@ -85,7 +83,14 @@ public void Render(ListView listView, bool selected, int item, int col, int line
     /// </summary>
     /// <param name="item">The index of the item to check.</param>
     /// <returns><see langword="true" /> if the item is marked; otherwise, <see langword="false" />.</returns>
-    public bool IsMarked(int item) => GridViewRowList[item].IsMarked;
+    public bool IsMarked(int item)
+    {
+        if (item < 0 || item >= GridViewRowList.Count)
+        {
+            return false;
+        }
+        return GridViewRowList[item].IsMarked;
+    }
 
     /// <summary>
     ///     Sets the marked state of the specified item and raises the <see cref="MarkChanged" /> event.

src/Microsoft.PowerShell.ConsoleGuiTools/Microsoft.PowerShell.ConsoleGuiTools.csproj

@@ -20,7 +20,7 @@
         <!-- Using local Terminal.Gui build for debugging -->
         <!--<ProjectReference Include="..\..\..\gui-cs\Terminal.Gui\Terminal.Gui\Terminal.Gui.csproj" />-->
         <PackageReference Include="Microsoft.PowerShell.SDK" Version="7.5.4" />
-        <PackageReference Include="Terminal.Gui" Version="2.0.0-develop.4827" />
+        <PackageReference Include="Terminal.Gui" Version="2.0.0-beta.11" />
     </ItemGroup>
 
     <ItemGroup>

src/Microsoft.PowerShell.ConsoleGuiTools/OutGridViewWindow.cs

@@ -368,17 +368,18 @@ private void AddListView()
             Y = _filterErrorView is not null ? Pos.Bottom(_filterErrorView) : 1,
             Width = Dim.Fill(),
             Height = Dim.Fill(1),
-            AllowsMarking = _applicationData.OutputMode != OutputModeOption.None,
-            AllowsMultipleSelection = _applicationData.OutputMode == OutputModeOption.Multiple,
+            ShowMarks = _applicationData.OutputMode != OutputModeOption.None,
+            MarkMultiple = _applicationData.OutputMode == OutputModeOption.Multiple,
             SelectedItem = 0,
-            VerticalScrollBar = { AutoShow = true },
-            HorizontalScrollBar = { AutoShow = true }
+            ViewportSettings = ViewportSettingsFlags.HasScrollBars
         };
 
         _listView.KeyBindings.Remove(Key.A.WithCtrl);
 
         if (!_applicationData.MinUI) AddHeader();
 
+        _listView.Accepted += (sender, args) => Accept();
+
         Add(_listView);
         return;
 
@@ -424,19 +425,7 @@ private void AddStatusBar()
         if (_applicationData.OutputMode != OutputModeOption.None)
             shortcuts.Add(new Shortcut(Key.Enter, "Accept", () =>
             {
-                if (MostFocused == _listView)
-                {
-                    if (_applicationData.OutputMode == OutputModeOption.Single &&
-                        _inputSource!.GridViewRowList.Find(i => i.IsMarked) == null)
-                        if (_listView!.SelectedItem is not null && _listView.SelectedItem < _listViewSource!.Count)
-                        {
-                            var item = _listViewSource.GridViewRowList[_listView.SelectedItem.Value];
-                            item.IsMarked = !item.IsMarked;
-                        }
-
-                    Accept();
-                }
-                else if (MostFocused == _filterField)
+                if (MostFocused == _filterField)
                 {
                     _listView!.SetFocus();
                 }
@@ -449,7 +438,7 @@ private void AddStatusBar()
             CommandView = new CheckBox
             {
                 Title = "A_ll Properties",
-                CheckedState = _applicationData.AllProperties ? CheckState.Checked : CheckState.UnChecked,
+                Value = _applicationData.AllProperties ? CheckState.Checked : CheckState.UnChecked,
                 CanFocus = false,
                 MouseHighlightStates = MouseState.None
             },

src/Microsoft.PowerShell.ConsoleGuiTools/Properties/launchSettings.json

@@ -38,7 +38,7 @@
     "gci | OCGV ": {
       "commandName": "Executable",
       "executablePath": "C:\\Program Files\\PowerShell\\7-preview\\pwsh.exe",
-      "commandLineArgs": "-NoProfile -NoLogo -NoExit -Command \"& { Import-Module '$(TargetPath)'; gci | Out-ConsoleGridView}\"",
+      "commandLineArgs": "-NoProfile -NoLogo -NoExit -Command \"& { Import-Module '$(TargetPath)'; gci | Out-ConsoleGridView -OutputMode: Single}\"",
       "workingDirectory": "$(TargetDir)"
     },
     "OCGV -AllProperties": {

src/Microsoft.PowerShell.ConsoleGuiTools/TypeGetter.cs

@@ -321,7 +321,7 @@ public static DataTableRow CastObjectToDataTableRow(PSObject psObject, List<Data
                     }
                 }
             }
-            catch (Exception ex)
+            catch (Exception _)
             {
                 // If evaluation fails, use null
                 result = null;