Fix y$ to yank to the end of the logical line instead of to the end of the whole buffer. (#1168)

Author: springcomp

PSReadLine/YankPaste.vi.cs

@@ -137,9 +137,13 @@ public static void ViYankLeft(ConsoleKeyInfo? key = null, object arg = null)
         /// </summary>
         public static void ViYankToEndOfLine(ConsoleKeyInfo? key = null, object arg = null)
         {
-            int start = _singleton._current;
-            int length = _singleton._buffer.Length - _singleton._current;
-            _singleton.SaveToClipboard(start, length);
+            var start = _singleton._current;
+            var end = GetEndOfLogicalLinePos(_singleton._current);
+            var length = end - start + 1;
+            if (length > 0)
+            {
+                _clipboard.Record(_singleton._buffer, start, length);
+            }
         }
 
         /// <summary>

test/YankPasteTest.VI.cs

@@ -337,6 +337,24 @@ public void ViPasteAfterYankBeginningOfLine()
                 ));
         }
 
+        [SkippableFact]
+        public void ViPasteAfterYankEndOfLine()
+        {
+            TestSetup(KeyMode.Vi);
+
+            var continuationPrefixLength = PSConsoleReadLineOptions.DefaultContinuationPrompt.Length;
+
+            Test("\"\nHello\nWorld!\n\"", Keys(
+                _.DQuote, _.Enter,
+                "Hello", _.Enter,
+                "World!", _.Enter, 
+                _.DQuote, _.Escape,
+                _.k, _.l, // move to the 'o' character of 'World!'
+                "y$P", CheckThat(() => AssertLineIs("\"\nHello\nWorld!orld!\n\"")), CheckThat(() => AssertCursorLeftIs(continuationPrefixLength + 5)),
+                "u"
+                ));
+        }
+
         [SkippableFact]
         public void ViPasteAfterYankFirstNoneBlank()
         {