Return error if color property or value is invalid with Set-PSReadLineOption -Colors (#1124)

Author: SteveL-MSFT

PSReadLine/Cmdlets.cs

@@ -483,6 +483,10 @@ internal void SetColor(string property, object value)
             {
                 setter(this, value);
             }
+            else
+            {
+                throw new ArgumentException(string.Format(CultureInfo.CurrentUICulture, PSReadLineResources.InvalidColorProperty, property));
+            }
         }
     }
 
@@ -964,7 +968,7 @@ public static string AsEscapeSequence(object o, bool isBackground)
                     break;
             }
 
-            throw new ArgumentException("o");
+            throw new ArgumentException(string.Format(CultureInfo.CurrentUICulture, PSReadLineResources.InvalidColorValue, o.ToString()));
         }
 
         public static string AsEscapeSequence(ConsoleColor fg, ConsoleColor bg)

PSReadLine/PSReadLineResources.Designer.cs

@@ -751,9 +751,6 @@ Or not saving history with:
   <data name="OopsCustomHandlerException" xml:space="preserve">
     <value>An exception occurred in custom key handler, see $error for more information: {0}</value>
   </data>
-  <data name="InvalidColorParameter" xml:space="preserve">
-    <value>Parameter must be a ConsoleColor, ANSI escape sequence, or RGB value with optional leading '#'.</value>
-  </data>
   <data name="BasicGrouping" xml:space="preserve">
     <value>Basic editing functions</value>
   </data>
@@ -778,4 +775,10 @@ Or not saving history with:
   <data name="CustomGrouping" xml:space="preserve">
     <value>User defined functions</value>
   </data>
+  <data name="InvalidColorValue" xml:space="preserve">
+    <value>'{0}' is not a valid color value.  It must be a ConsoleColor, ANSI escape sequence, or RGB value with optional leading '#'.</value>
+  </data>
+  <data name="InvalidColorProperty" xml:space="preserve">
+    <value>'{0}' is not a valid color property</value>
+  </data>
 </root>

PSReadLine/PSReadLineResources.resx

@@ -78,6 +78,34 @@ public void GetKeyHandlers()
             }
         }
 
+        [SkippableFact]
+        public void SetInvalidColorOptions()
+        {
+            bool throws = false;
+            try
+            {
+                PSConsoleReadLine.SetOptions(new SetPSReadLineOption{
+                    Colors = new Hashtable {
+                        { "InvalidProperty", ConsoleColor.Magenta }
+                    },
+                });
+            }
+            catch (ArgumentException) { throws = true; }
+            Assert.True(throws, "Invalid color property should throw");
+
+            throws = false;
+            try
+            {
+                PSConsoleReadLine.SetOptions(new SetPSReadLineOption{
+                    Colors = new Hashtable {
+                        { "Default", "apple" }
+                    },
+                });
+            }
+            catch (ArgumentException) { throws = true; }
+            Assert.True(throws, "Invalid color value should throw");
+        }
+
         [SkippableFact]
         [ExcludeFromCodeCoverage]
         public void UselessStuffForBetterCoverage()