fix(json): 🐛 Improve error handling for file and template actions

* Added checks to ensure both `source` and `destination` properties are provided for `file` and `templateFile` actions.
* Enhanced error messages for better clarity on missing properties.
* Updated JSON manifest example to reflect the change from `file` to `directory` type for better structure.

Author: HeyItsGilbert

Plaster/Private/ConvertFrom-JsonContentAction.ps1

@@ -82,18 +82,18 @@ function ConvertFrom-JsonContentAction {
                     if ($modification.isRegex) {
                         $originalElement.SetAttribute('expand', 'true')
                     }
-                    $replaceElement.AppendChild($originalElement)
+                    [void]$replaceElement.AppendChild($originalElement)
 
                     $substituteElement = $XmlDocument.CreateElement('substitute', $TargetNamespace)
                     $substituteElement.InnerText = $modification.replace
                     $substituteElement.SetAttribute('expand', 'true')
-                    $replaceElement.AppendChild($substituteElement)
+                    [void]$replaceElement.AppendChild($substituteElement)
 
                     if ($modification.condition) {
                         $replaceElement.SetAttribute('condition', $modification.condition)
                     }
 
-                    $element.AppendChild($replaceElement)
+                    [void]$element.AppendChild($replaceElement)
                 }
             }
         }

Plaster/Private/ConvertFrom-JsonManifest.ps1

@@ -39,7 +39,7 @@ function ConvertFrom-JsonManifest {
 
             # Add metadata
             $metadataElement = $xmlDoc.CreateElement('metadata', $TargetNamespace)
-            $manifest.AppendChild($metadataElement)
+            [void]$manifest.AppendChild($metadataElement)
 
             # Add metadata properties
             $metadataProperties = @('name', 'id', 'version', 'title', 'description', 'author', 'tags')
@@ -53,13 +53,13 @@ function ConvertFrom-JsonManifest {
                     } else {
                         $element.InnerText = $value
                     }
-                    $metadataElement.AppendChild($element)
+                    [void]$metadataElement.AppendChild($element)
                 }
             }
 
             # Add parameters
             $parametersElement = $xmlDoc.CreateElement('parameters', $TargetNamespace)
-            $manifest.AppendChild($parametersElement)
+            [void]$manifest.AppendChild($parametersElement)
 
             if ($jsonObject.parameters) {
                 foreach ($param in $jsonObject.parameters) {
@@ -98,21 +98,21 @@ function ConvertFrom-JsonManifest {
                                 $choiceElement.SetAttribute('help', $choice.help)
                             }
 
-                            $paramElement.AppendChild($choiceElement)
+                            [void]$paramElement.AppendChild($choiceElement)
                         }
                     }
 
-                    $parametersElement.AppendChild($paramElement)
+                    [void]$parametersElement.AppendChild($paramElement)
                 }
             }
 
             # Add content
             $contentElement = $xmlDoc.CreateElement('content', $TargetNamespace)
-            $manifest.AppendChild($contentElement)
+            [void]$manifest.AppendChild($contentElement)
 
             foreach ($action in $jsonObject.content) {
                 $actionElement = ConvertFrom-JsonContentAction -Action $action -XmlDocument $xmlDoc
-                $contentElement.AppendChild($actionElement)
+                [void]$contentElement.AppendChild($actionElement)
             }
 
             Write-PlasterLog -Level Debug -Message "JSON to XML conversion completed successfully"

Plaster/Private/Test-JsonManifestContent.ps1

@@ -23,12 +23,26 @@ function Test-JsonManifestContent {
                 }
             }
             'file' {
-                if (-not $action.source -or -not $action.destination) {
+                # Both source and destination cannot be empty/missing
+                # Empty destination means copy to root, empty source would be directory (but should use 'directory' type)
+                if ((-not $action.source -and -not $action.destination) -or
+                    (-not $action.PSObject.Properties['source'] -and -not $action.PSObject.Properties['destination'])) {
+                    throw "File action missing required 'source' or 'destination' property"
+                }
+                # At least one must be non-empty
+                if ([string]::IsNullOrWhiteSpace($action.source) -and [string]::IsNullOrWhiteSpace($action.destination)) {
                     throw "File action missing required 'source' or 'destination' property"
                 }
             }
             'templateFile' {
-                if (-not $action.source -or -not $action.destination) {
+                # Both source and destination cannot be empty/missing
+                # Empty destination means copy to root
+                if ((-not $action.source -and -not $action.destination) -or
+                    (-not $action.PSObject.Properties['source'] -and -not $action.PSObject.Properties['destination'])) {
+                    throw "TemplateFile action missing required 'source' or 'destination' property"
+                }
+                # At least one must be non-empty
+                if ([string]::IsNullOrWhiteSpace($action.source) -and [string]::IsNullOrWhiteSpace($action.destination)) {
                     throw "TemplateFile action missing required 'source' or 'destination' property"
                 }
             }

examples/plasterManifest.json

@@ -163,8 +163,7 @@
             "condition": "${Options} -contains 'PSake'"
         },
         {
-            "type": "file",
-            "source": "",
+            "type": "directory",
             "destination": "docs\\",
             "condition": "${Options} -contains 'platyPS'"
         },