!37 fixt(RiskEnum): [#75] MEDIUM RISK not well represented Closes #75

Author: João Silva

probely_cli/sdk/common.py

@@ -20,7 +20,7 @@ class TargetRiskEnum(ProbelyCLIEnum):
     NA = (None, "null")
     NO_RISK = (0, "0")
     LOW = (10, "10")
-    NORMAL = (20, "20")
+    MEDIUM = (20, "20")
     HIGH = (30, "30")
 
 
@@ -31,7 +31,7 @@ class TargetTypeEnum(ProbelyCLIEnum):
 
 class FindingSeverityEnum(ProbelyCLIEnum):
     LOW = (TargetRiskEnum.LOW.value, TargetRiskEnum.LOW.api_filter_value)
-    NORMAL = (TargetRiskEnum.NORMAL.value, TargetRiskEnum.NORMAL.api_filter_value)
+    MEDIUM = (TargetRiskEnum.MEDIUM.value, TargetRiskEnum.MEDIUM.api_filter_value)
     HIGH = (TargetRiskEnum.HIGH.value, TargetRiskEnum.HIGH.api_filter_value)
 
 

probely_cli/sdk/targets.py

@@ -105,7 +105,7 @@ def list_targets(targets_filters: dict = None) -> List[Dict]:
     return resp_content["results"]
 
 
-def add_target(  # TODO: needs testing
+def add_target(
     target_url: str,
     target_name: Union[str, None] = None,
     target_type: TargetTypeEnum = TargetTypeEnum.WEB,

tests/cli/test_findings_get.py

@@ -74,7 +74,7 @@ def test_findings_get__table_last_found_date_output(
     [
         (0, "UNKNOWN"),
         (10, FindingSeverityEnum.LOW.name),
-        (20, FindingSeverityEnum.NORMAL.name),
+        (20, FindingSeverityEnum.MEDIUM.name),
         (30, FindingSeverityEnum.HIGH.name),
         (None, "UNKNOWN"),
         (323232320, "UNKNOWN"),
@@ -169,8 +169,8 @@ def test_findings_get__table_labels_output(
             {"severity": [FindingSeverityEnum.LOW.api_filter_value]},
         ),
         (
-            f"--f-severity={FindingSeverityEnum.NORMAL.name}",
-            {"severity": [FindingSeverityEnum.NORMAL.api_filter_value]},
+            f"--f-severity={FindingSeverityEnum.MEDIUM.name}",
+            {"severity": [FindingSeverityEnum.MEDIUM.api_filter_value]},
         ),
         (
             f"--f-severity {FindingSeverityEnum.LOW.name} {FindingSeverityEnum.HIGH.name}",
@@ -247,11 +247,11 @@ def test_findings_get__arg_filters_success(
         ),
         (
             "--f-severity=invalid_value",
-            "error: argument --f-severity: invalid choice: 'INVALID_VALUE' (choose from 'LOW', 'NORMAL', 'HIGH')",
+            "error: argument --f-severity: invalid choice: 'INVALID_VALUE' (choose from 'LOW', 'MEDIUM', 'HIGH')",
         ),
         (
             "--f-severity invalid_value",
-            "error: argument --f-severity: invalid choice: 'INVALID_VALUE' (choose from 'LOW', 'NORMAL', 'HIGH')",
+            "error: argument --f-severity: invalid choice: 'INVALID_VALUE' (choose from 'LOW', 'MEDIUM', 'HIGH')",
         ),
         (
             "--f-state",

tests/cli/test_targets_get.py

@@ -73,7 +73,7 @@ def test_targets_get__table_last_scan_date_output(
     [
         (0, TargetRiskEnum.NO_RISK.name),
         (10, TargetRiskEnum.LOW.name),
-        (20, TargetRiskEnum.NORMAL.name),
+        (20, TargetRiskEnum.MEDIUM.name),
         (30, TargetRiskEnum.HIGH.name),
         (None, TargetRiskEnum.NA.name),
         (323232320, "UNKNOWN"),
@@ -164,11 +164,11 @@ def test_targets_get__table_labels_output(
             },
         ),
         (
-            "--f-risk high normal",
+            "--f-risk high medium",
             {
                 "risk": [
                     TargetRiskEnum.HIGH.api_filter_value,
-                    TargetRiskEnum.NORMAL.api_filter_value,
+                    TargetRiskEnum.MEDIUM.api_filter_value,
                 ]
             },
         ),
@@ -241,11 +241,11 @@ def test_targets_get__arg_filters_success(
         ),
         (
             "--f-risk=random_value",
-            "error: argument --f-risk: invalid choice: 'RANDOM_VALUE' (choose from 'NA', 'NO_RISK', 'LOW', 'NORMAL', 'HIGH')",
+            "error: argument --f-risk: invalid choice: 'RANDOM_VALUE' (choose from 'NA', 'NO_RISK', 'LOW', 'MEDIUM', 'HIGH')",
         ),
         (
             "--f-risk=",
-            "error: argument --f-risk: invalid choice: '' (choose from 'NA', 'NO_RISK', 'LOW', 'NORMAL', 'HIGH')",
+            "error: argument --f-risk: invalid choice: '' (choose from 'NA', 'NO_RISK', 'LOW', 'MEDIUM', 'HIGH')",
         ),
         (
             "--f-type=random_value, ",