-
Notifications
You must be signed in to change notification settings - Fork 32
Expand file tree
/
Copy pathModelSelectionTests.cs
More file actions
768 lines (661 loc) · 28.2 KB
/
ModelSelectionTests.cs
File metadata and controls
768 lines (661 loc) · 28.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
using PolyPilot.Models;
using PolyPilot.Services;
namespace PolyPilot.Tests;
public class ModelSelectionTests
{
// === ModelHelper.NormalizeToSlug tests ===
[Theory]
[InlineData("claude-opus-4.6", "claude-opus-4.6")]
[InlineData("claude-sonnet-4.5", "claude-sonnet-4.5")]
[InlineData("gemini-3-pro-preview", "gemini-3-pro-preview")]
[InlineData("gpt-5.4", "gpt-5.4")]
[InlineData("gpt-5.4-mini", "gpt-5.4-mini")]
[InlineData("gpt-5.3-codex", "gpt-5.3-codex")]
[InlineData("gpt-5.1-codex", "gpt-5.1-codex")]
[InlineData("claude-haiku-4.5", "claude-haiku-4.5")]
public void NormalizeToSlug_AlreadySlug_ReturnsUnchanged(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData("Claude Opus 4.6", "claude-opus-4.6")]
[InlineData("Claude Sonnet 4.5", "claude-sonnet-4.5")]
[InlineData("Claude Haiku 4.5", "claude-haiku-4.5")]
[InlineData("Claude Opus 4.5", "claude-opus-4.5")]
[InlineData("Claude Sonnet 4", "claude-sonnet-4")]
public void NormalizeToSlug_DisplayName_ConvertsToClaude(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData("GPT-5.4", "gpt-5.4")]
[InlineData("GPT-5.4-Mini", "gpt-5.4-mini")]
[InlineData("GPT-5.2", "gpt-5.2")]
[InlineData("GPT-5.1-Codex", "gpt-5.1-codex")]
[InlineData("GPT-5.1-Codex-Max", "gpt-5.1-codex-max")]
[InlineData("GPT-5.1-Codex-Mini", "gpt-5.1-codex-mini")]
[InlineData("GPT-5", "gpt-5")]
[InlineData("GPT-5-Mini", "gpt-5-mini")]
[InlineData("GPT-4.1", "gpt-4.1")]
public void NormalizeToSlug_DisplayName_ConvertsToGpt(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData("Gemini 3 Pro (Preview)", "gemini-3-pro-preview")]
[InlineData("Gemini 3 Pro", "gemini-3-pro")]
public void NormalizeToSlug_DisplayName_ConvertsToGemini(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData("Claude Opus 4.6 (fast mode)", "claude-opus-4.6-fast")]
[InlineData("Claude Opus 4.6 (fast)", "claude-opus-4.6-fast")]
public void NormalizeToSlug_DisplayName_WithFastSuffix(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData("Claude Opus 4.6 (1M Context)(Internal Only)", "claude-opus-4.6-1m")]
[InlineData("Claude Opus 4.6 (1M Context)", "claude-opus-4.6-1m")]
[InlineData("claude-opus-4.6-1m", "claude-opus-4.6-1m")]
public void NormalizeToSlug_DisplayName_With1MSuffix(string input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Theory]
[InlineData(null, "")]
[InlineData("", "")]
[InlineData(" ", "")]
public void NormalizeToSlug_NullOrEmpty_ReturnsEmpty(string? input, string expected)
{
Assert.Equal(expected, ModelHelper.NormalizeToSlug(input));
}
[Fact]
public void NormalizeToSlug_WithWhitespace_Trims()
{
Assert.Equal("claude-opus-4.6", ModelHelper.NormalizeToSlug(" claude-opus-4.6 "));
Assert.Equal("claude-opus-4.5", ModelHelper.NormalizeToSlug(" Claude Opus 4.5 "));
}
// === IsDisplayName tests ===
[Theory]
[InlineData("Claude Opus 4.5", true)]
[InlineData("GPT-5.1-Codex", true)]
[InlineData("Gemini 3 Pro (Preview)", true)]
[InlineData("claude-opus-4.5", false)]
[InlineData("gpt-5.1-codex", false)]
[InlineData("gemini-3-pro-preview", false)]
[InlineData(null, false)]
[InlineData("", false)]
public void IsDisplayName_DetectsCorrectly(string? input, bool expected)
{
Assert.Equal(expected, ModelHelper.IsDisplayName(input));
}
// === Round-trip test: display names from known SDK event patterns ===
[Fact]
public void NormalizeToSlug_AllFallbackModels_AreAlreadySlugs()
{
foreach (var model in ModelHelper.FallbackModels)
{
var normalized = ModelHelper.NormalizeToSlug(model);
Assert.Equal(model, normalized);
}
}
[Fact]
public void BuildSelectionList_AppendsSelectionAndDefault_WhenDiscoveryIsEmpty()
{
var models = ModelHelper.BuildSelectionList(Array.Empty<string>(), "Custom Preview", "claude-opus-4.6");
Assert.Equal(new[] { "custom-preview", "claude-opus-4.6" }, models);
}
[Fact]
public void BuildSelectionList_NormalizesDiscoveredModels_AndAvoidsDuplicates()
{
var models = ModelHelper.BuildSelectionList(
new[] { "Claude Opus 4.6", "claude-opus-4.6", "Custom Preview" },
"custom-preview",
"claude-opus-4.6");
Assert.Equal(new[] { "claude-opus-4.6", "custom-preview" }, models);
}
[Fact]
public void ShouldAcceptObservedModel_EmptyCurrentModel_AcceptsObserved()
{
Assert.True(ModelHelper.ShouldAcceptObservedModel("", "claude-opus-4.6"));
Assert.True(ModelHelper.ShouldAcceptObservedModel("resumed", "claude-opus-4.6"));
}
[Fact]
public void ShouldAcceptObservedModel_SameModel_AcceptsObserved()
{
Assert.True(ModelHelper.ShouldAcceptObservedModel("Claude Opus 4.6", "claude-opus-4.6"));
}
[Fact]
public void ShouldAcceptObservedModel_DifferentObservedModel_PreservesExplicitChoice()
{
Assert.False(ModelHelper.ShouldAcceptObservedModel("gpt-5.4", "claude-opus-4.6"));
Assert.False(ModelHelper.ShouldAcceptObservedModel("claude-haiku-4.5", "claude-opus-4.6"));
}
[Fact]
public void NormalizeToSlug_DisplayNamesFromCliEvents_MatchSlugs()
{
// These are actual display names observed in session.start events from the CLI
var displayToSlug = new Dictionary<string, string>
{
{ "Claude Opus 4.5", "claude-opus-4.5" },
{ "Claude Sonnet 4.5", "claude-sonnet-4.5" },
{ "Claude Opus 4.6 (fast mode)", "claude-opus-4.6-fast" },
};
foreach (var (display, expectedSlug) in displayToSlug)
{
Assert.Equal(expectedSlug, ModelHelper.NormalizeToSlug(display));
}
}
// === AgentSessionInfo model property tests ===
[Fact]
public void AgentSessionInfo_Model_CanBeSetToSlug()
{
var info = new AgentSessionInfo { Name = "test", Model = "claude-opus-4.6" };
Assert.Equal("claude-opus-4.6", info.Model);
}
[Fact]
public void AgentSessionInfo_Model_DisplayNameShouldBeNormalized()
{
// This tests the pattern: receive display name from event, normalize before storing
var displayName = "Claude Opus 4.5";
var normalized = ModelHelper.NormalizeToSlug(displayName);
var info = new AgentSessionInfo { Name = "test", Model = normalized };
Assert.Equal("claude-opus-4.5", info.Model);
}
// === Session creation model flow test ===
[Fact]
public void CreateSession_ModelPassedCorrectly()
{
// Simulates the flow: UI selectedModel → CreateSessionAsync model param → SessionConfig.Model
var uiSelectedModel = "claude-opus-4.6"; // From dropdown (slug)
var sessionModel = uiSelectedModel; // model ?? DefaultModel
Assert.Equal("claude-opus-4.6", sessionModel);
}
[Fact]
public void CreateSession_DisplayNameFromUiState_IsNormalized()
{
// Simulates: UI state has display name → normalize → pass to CreateSessionAsync
var savedModel = "Claude Sonnet 4.5"; // From corrupted ui-state.json
var normalized = ModelHelper.NormalizeToSlug(savedModel);
Assert.Equal("claude-sonnet-4.5", normalized);
}
// === UiState model persistence tests ===
[Fact]
public void UiState_SelectedModel_NormalizationNeeded()
{
// Verify that a display name in UiState would be normalized on load
var displayName = "Claude Opus 4.5";
var slug = ModelHelper.NormalizeToSlug(displayName);
Assert.False(ModelHelper.IsDisplayName(slug));
Assert.Equal("claude-opus-4.5", slug);
}
[Fact]
public void ActiveSessionEntry_Model_NormalizationNeeded()
{
// Verify that display names from persisted entries are normalized correctly
var displayModel = "Claude Opus 4.5";
var normalized = ModelHelper.NormalizeToSlug(displayModel);
Assert.Equal("claude-opus-4.5", normalized);
}
// === Session resume model + working directory preservation ===
[Fact]
public void ResumeFlow_ActiveSessionEntry_PreservesModelAndWorkingDirectory()
{
// Simulates the full save → restore cycle for active sessions
var entries = new List<ActiveSessionEntry>
{
new()
{
SessionId = "2a6c8495-20a8-4026-88e8-a4626b915b7a",
DisplayName = "TestFromTree",
Model = "claude-opus-4.5",
WorkingDirectory = "/Users/test/.polypilot/worktrees/dotnet-maui-8f45001d"
}
};
var json = System.Text.Json.JsonSerializer.Serialize(entries);
var restored = System.Text.Json.JsonSerializer.Deserialize<List<ActiveSessionEntry>>(json);
Assert.NotNull(restored);
var entry = restored![0];
// These are the critical fields that MUST survive the round-trip
Assert.Equal("claude-opus-4.5", entry.Model);
Assert.Equal("/Users/test/.polypilot/worktrees/dotnet-maui-8f45001d", entry.WorkingDirectory);
// Model must be a slug, not a display name
Assert.False(ModelHelper.IsDisplayName(entry.Model), "Persisted model should be a slug, not a display name");
}
[Fact]
public void ResumeFlow_DisplayNameModel_IsNormalizedBeforeResume()
{
// Simulates: old active-sessions.json has display name → normalize before passing to SDK
var entry = new ActiveSessionEntry
{
SessionId = "some-guid",
DisplayName = "MySession",
Model = "Claude Opus 4.5", // Display name from older persistence
WorkingDirectory = "/some/worktree/path"
};
var resumeModel = ModelHelper.NormalizeToSlug(entry.Model);
Assert.Equal("claude-opus-4.5", resumeModel);
Assert.False(ModelHelper.IsDisplayName(resumeModel));
}
[Fact]
public void ResumeFlow_EmptyModel_FallsBackToDefault()
{
// If the persisted model is empty, the resume should use DefaultModel
var defaultModel = "claude-opus-4.6";
string? persistedModel = null;
var resumeModel = ModelHelper.NormalizeToSlug(persistedModel ?? defaultModel);
Assert.Equal("claude-opus-4.6", resumeModel);
}
[Fact]
public void ResumeFlow_LatestEventModel_WinsOverPersistedEntry()
{
var entry = new ActiveSessionEntry
{
SessionId = "some-guid",
DisplayName = "MySession",
Model = "gpt-5.3-codex",
WorkingDirectory = "/some/worktree/path"
};
var lines = new[]
{
"""{"type":"session.start","data":{"selectedModel":"gpt-5.3-codex","context":{"cwd":"/tmp"}}}""",
"""{"type":"session.model_change","data":{"newModel":"GPT-5.4"}}""",
};
var resumeModel = ModelHelper.ExtractLatestModelFromEvents(lines)
?? ModelHelper.NormalizeToSlug(entry.Model);
Assert.Equal("gpt-5.4", resumeModel);
}
[Fact]
public void ResumeFlow_WorkingDirectory_NotOverriddenByProjectDir()
{
// The key invariant: a worktree session must keep its worktree path,
// NOT fall back to the PolyPilot project directory
var worktreePath = "/Users/test/.polypilot/worktrees/dotnet-maui-8f45001d";
var projectDir = "/Users/test/Projects/AutoPilot/PolyPilot";
// Simulates: workingDirectory param is set → should win over any fallback
var resolvedDir = worktreePath ?? projectDir;
Assert.Equal(worktreePath, resolvedDir);
Assert.NotEqual(projectDir, resolvedDir);
}
// === Normalization idempotency ===
[Fact]
public void NormalizeToSlug_IsIdempotent()
{
// Normalizing an already-normalized slug should return the same value
var slugs = new[]
{
"claude-opus-4.6", "claude-opus-4.6-fast", "claude-sonnet-4.5",
"gpt-5.1-codex", "gemini-3-pro-preview"
};
foreach (var slug in slugs)
{
var once = ModelHelper.NormalizeToSlug(slug);
var twice = ModelHelper.NormalizeToSlug(once);
Assert.Equal(once, twice);
}
}
[Fact]
public void NormalizeToSlug_DisplayNames_AreIdempotentAfterFirstPass()
{
// Normalizing a display name, then normalizing the result, must be stable
var displayNames = new[]
{
"Claude Opus 4.6", "Claude Opus 4.6 (fast mode)", "GPT-5.1-Codex",
"Gemini 3 Pro (Preview)", "Claude Sonnet 4.5"
};
foreach (var name in displayNames)
{
var once = ModelHelper.NormalizeToSlug(name);
var twice = ModelHelper.NormalizeToSlug(once);
Assert.Equal(once, twice);
}
}
// === End-to-end persistence scenario ===
[Fact]
public void EndToEnd_CreateSaveRestoreResume_PreservesContext()
{
// Full lifecycle: create session → save to active-sessions.json → restore → resume
// This is the exact flow that was broken (PR 90 bug)
// Step 1: Session created with specific model + worktree
var createdModel = "claude-opus-4.5";
var createdWorkDir = "/Users/test/.polypilot/worktrees/dotnet-maui-abc123";
var info = new AgentSessionInfo
{
Name = "MauiWorktreeSession",
Model = createdModel,
WorkingDirectory = createdWorkDir,
SessionId = "fake-guid-1234"
};
// Step 2: Save to disk (SaveActiveSessionsToDisk pattern)
var entry = new ActiveSessionEntry
{
SessionId = info.SessionId!,
DisplayName = info.Name,
Model = info.Model,
WorkingDirectory = info.WorkingDirectory
};
// Step 3: Serialize + deserialize (simulates app restart)
var json = System.Text.Json.JsonSerializer.Serialize(new[] { entry });
var restored = System.Text.Json.JsonSerializer.Deserialize<List<ActiveSessionEntry>>(json)!;
var restoredEntry = restored[0];
// Step 4: Resume would use these values
var resumeModel = ModelHelper.NormalizeToSlug(restoredEntry.Model);
var resumeWorkDir = restoredEntry.WorkingDirectory;
// ASSERTIONS: Everything must match the original creation values
Assert.Equal(createdModel, resumeModel);
Assert.Equal(createdWorkDir, resumeWorkDir);
Assert.Equal("MauiWorktreeSession", restoredEntry.DisplayName);
Assert.False(ModelHelper.IsDisplayName(resumeModel), "Resume model must be a slug");
}
[Fact]
public void EndToEnd_LegacyDisplayNameEntry_IsNormalizedOnResume()
{
// Simulates restoring an entry that was saved before the normalization fix
var legacyJson = @"[{
""SessionId"": ""old-guid"",
""DisplayName"": ""OldSession"",
""Model"": ""Claude Opus 4.5"",
""WorkingDirectory"": ""/some/worktree""
}]";
var entries = System.Text.Json.JsonSerializer.Deserialize<List<ActiveSessionEntry>>(legacyJson)!;
var entry = entries[0];
// The restore path should normalize the model
var resumeModel = ModelHelper.NormalizeToSlug(entry.Model);
Assert.Equal("claude-opus-4.5", resumeModel);
Assert.Equal("/some/worktree", entry.WorkingDirectory);
}
// === ChangeModelAsync behavior tests ===
[Fact]
public void ChangeModel_NewModelIsNormalized()
{
// ChangeModelAsync normalizes before use — display names from UI must become slugs
var userSelection = "Claude Opus 4.6";
var normalized = ModelHelper.NormalizeToSlug(userSelection);
Assert.Equal("claude-opus-4.6", normalized);
}
[Fact]
public void ChangeModel_SameModel_IsNoOp()
{
// If current model == requested model, ChangeModelAsync should be a no-op
var currentModel = "claude-opus-4.5";
var requested = "claude-opus-4.5";
var normalizedRequested = ModelHelper.NormalizeToSlug(requested);
Assert.Equal(currentModel, normalizedRequested); // Would trigger no-op guard
}
[Fact]
public void ChangeModel_DifferentModel_UpdatesInfo()
{
// Simulates what ChangeModelAsync does to AgentSessionInfo after successful resume
var info = new AgentSessionInfo
{
Name = "TestSession",
Model = "claude-sonnet-4.5",
SessionId = "some-guid",
WorkingDirectory = "/some/worktree"
};
var newModel = ModelHelper.NormalizeToSlug("claude-opus-4.6");
Assert.NotEqual(info.Model, newModel); // Different model → would proceed
// After successful resume, model is updated
info.Model = newModel;
Assert.Equal("claude-opus-4.6", info.Model);
// Working directory must NOT change during model switch
Assert.Equal("/some/worktree", info.WorkingDirectory);
}
[Fact]
public void ChangeModel_PreservesSessionIdentity()
{
// Model switch reconnects the same session ID — history is preserved server-side
var info = new AgentSessionInfo
{
Name = "MySession",
Model = "gpt-5.1-codex",
SessionId = "fixed-guid-123",
WorkingDirectory = "/my/worktree"
};
info.History.Add(ChatMessage.UserMessage("hello"));
info.History.Add(new ChatMessage("assistant", "hi there", DateTimeOffset.UtcNow));
var originalSessionId = info.SessionId;
var originalHistory = info.History.Count;
var originalName = info.Name;
var originalWorkDir = info.WorkingDirectory;
// Simulate model switch
info.Model = ModelHelper.NormalizeToSlug("claude-opus-4.6");
// Everything except model must be unchanged
Assert.Equal(originalSessionId, info.SessionId);
Assert.Equal(originalHistory, info.History.Count);
Assert.Equal(originalName, info.Name);
Assert.Equal(originalWorkDir, info.WorkingDirectory);
Assert.Equal("claude-opus-4.6", info.Model);
}
[Fact]
public void ChangeModel_DisplayNameFromDropdown_NormalizesToSlug()
{
// The UI dropdown shows display names but passes slugs.
// If somehow a display name gets through, ChangeModelAsync must normalize it.
var displayNames = new Dictionary<string, string>
{
{ "Claude Opus 4.6 (fast mode)", "claude-opus-4.6-fast" },
{ "Gemini 3 Pro (Preview)", "gemini-3-pro-preview" },
{ "GPT-5.1-Codex-Max", "gpt-5.1-codex-max" },
};
foreach (var (display, expectedSlug) in displayNames)
{
var normalized = ModelHelper.NormalizeToSlug(display);
Assert.Equal(expectedSlug, normalized);
Assert.False(ModelHelper.IsDisplayName(normalized));
}
}
[Fact]
public void BuildSelectionList_PreservesDiscoveryOrder_AndAppendsMissingRequiredModels()
{
var models = ModelHelper.BuildSelectionList(
new[] { "claude-sonnet-4.6", "Claude Opus 4.6", "gpt-5.4" },
"claude-opus-4.6",
"gpt-5-mini");
Assert.Equal(
new[] { "claude-sonnet-4.6", "claude-opus-4.6", "gpt-5.4", "gpt-5-mini" },
models);
}
// --- PrettifyModel tests ---
// The prettifier is duplicated in ExpandedSessionView.razor and ModelSelector.razor.
// We test the logic inline here to catch regressions like the "Opus-4.5" bug.
/// <summary>
/// Mirror of the PrettifyModel logic from ExpandedSessionView.razor / ModelSelector.razor.
/// </summary>
private static string PrettifyModel(string modelId)
{
var display = modelId
.Replace("claude-", "Claude ")
.Replace("gpt-", "GPT-")
.Replace("gemini-", "Gemini ");
display = display.Replace("-", " ");
display = display.Replace("GPT ", "GPT-");
return string.Join(' ', display.Split(' ', StringSplitOptions.RemoveEmptyEntries).Select(s =>
s.Length > 0 ? char.ToUpper(s[0]) + s[1..] : s));
}
[Theory]
[InlineData("claude-opus-4.5", "Claude Opus 4.5")]
[InlineData("claude-opus-4.6-fast", "Claude Opus 4.6 Fast")]
[InlineData("claude-sonnet-4.5", "Claude Sonnet 4.5")]
[InlineData("claude-haiku-4.5", "Claude Haiku 4.5")]
[InlineData("gpt-5.1-codex-max", "GPT-5.1 Codex Max")]
[InlineData("gpt-5.1-codex-mini", "GPT-5.1 Codex Mini")]
[InlineData("gpt-5.2-codex", "GPT-5.2 Codex")]
[InlineData("gpt-5-mini", "GPT-5 Mini")]
[InlineData("gemini-3-pro-preview", "Gemini 3 Pro Preview")]
public void PrettifyModel_ProducesReadableNames(string slug, string expected)
{
Assert.Equal(expected, PrettifyModel(slug));
}
[Theory]
[InlineData("claude-opus-4.5")]
[InlineData("gpt-5.1-codex")]
[InlineData("gemini-3-pro-preview")]
public void PrettifyModel_NoDuplicateHyphens(string slug)
{
var pretty = PrettifyModel(slug);
// Should not contain stray hyphens (except GPT- prefix)
var withoutGpt = pretty.Replace("GPT-", "GPT");
Assert.DoesNotContain("-", withoutGpt);
}
[Fact]
public void PrettifyModel_DoesNotProduceDuplicateEntries()
{
// Regression: "claude-opus-4.5" was prettified to "Claude Opus-4.5"
// which didn't match the display name "Claude Opus 4.5", causing duplicates in the dropdown
var slugs = new[] { "claude-opus-4.5", "claude-sonnet-4.5", "gpt-5.1-codex-max" };
foreach (var slug in slugs)
{
var pretty = PrettifyModel(slug);
Assert.DoesNotContain("-", pretty.Replace("GPT-", "GPT"));
// Prettifying twice should be stable
Assert.Equal(pretty, PrettifyModel(slug));
}
}
[Fact]
public void RecreateSession_UsesNormalizedModel()
{
// When RecreateSessionAsync is called, the model should be normalized
// before being passed to CreateSessionAsync
var displayName = "Claude Opus 4.5";
var normalized = ModelHelper.NormalizeToSlug(displayName);
Assert.Equal("claude-opus-4.5", normalized);
// The recreated session should use the slug, not the display name
Assert.False(ModelHelper.IsDisplayName(normalized));
}
[Theory]
[InlineData("claude-opus-4.5")]
[InlineData("gpt-5.1-codex-max")]
[InlineData("gemini-3-pro-preview")]
[InlineData("claude-opus-4.6-fast")]
public void RoundTrip_NormalizeAndPrettify_AreConsistent(string slug)
{
// Prettify a slug, then normalize back — should return the original slug
var pretty = PrettifyModel(slug);
var backToSlug = ModelHelper.NormalizeToSlug(pretty);
Assert.Equal(slug, backToSlug);
}
[Fact]
public void ResolvePreferredModel_PreferredAvailable_ReturnsPreferred()
{
var available = new List<string> { "claude-opus-4.6-1m", "claude-opus-4.6", "claude-sonnet-4.6" };
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", available, "claude-opus-4.6");
Assert.Equal("claude-opus-4.6-1m", result);
}
[Fact]
public void ResolvePreferredModel_PreferredUnavailable_ReturnsFallback()
{
var available = new List<string> { "claude-opus-4.6", "claude-sonnet-4.6" };
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", available, "claude-opus-4.6");
Assert.Equal("claude-opus-4.6", result);
}
[Fact]
public void ResolvePreferredModel_NothingAvailable_ReturnsPreferred()
{
var available = new List<string> { "gpt-5.4", "gpt-5.1" };
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", available, "claude-opus-4.6");
Assert.Equal("claude-opus-4.6-1m", result);
}
[Fact]
public void ResolvePreferredModel_NullAvailableList_ReturnsPreferred()
{
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", null, "claude-opus-4.6");
Assert.Equal("claude-opus-4.6-1m", result);
}
[Fact]
public void ResolvePreferredModel_EmptyAvailableList_ReturnsPreferred()
{
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", new List<string>(), "claude-opus-4.6");
Assert.Equal("claude-opus-4.6-1m", result);
}
[Fact]
public void ResolvePreferredModel_CaseInsensitive()
{
var available = new List<string> { "Claude-Opus-4.6-1M" };
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", available, "claude-opus-4.6");
Assert.Equal("claude-opus-4.6-1m", result);
}
[Fact]
public void ResolvePreferredModel_MultipleFallbacks_ReturnsFirst()
{
var available = new List<string> { "claude-sonnet-4.6" };
var result = ModelHelper.ResolvePreferredModel("claude-opus-4.6-1m", available, "claude-opus-4.6", "claude-sonnet-4.6");
Assert.Equal("claude-sonnet-4.6", result);
}
// === GetCapabilitiesOverride tests ===
[Theory]
[InlineData("gemini-3-pro")]
[InlineData("gemini-3-pro-preview")]
public void GetCapabilitiesOverride_VisionModel_SetsVisionSupport(string model)
{
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.NotNull(result);
Assert.NotNull(result.Supports);
Assert.True(result.Supports!.Vision);
}
[Theory]
[InlineData("gemini-3-pro")]
[InlineData("gemini-3-pro-preview")]
public void GetCapabilitiesOverride_VisionModel_SetsVisionLimits(string model)
{
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.NotNull(result);
Assert.NotNull(result.Limits);
Assert.NotNull(result.Limits!.Vision);
Assert.NotNull(result.Limits.Vision!.SupportedMediaTypes);
Assert.Contains("image/png", result.Limits.Vision.SupportedMediaTypes!);
Assert.Contains("image/jpeg", result.Limits.Vision.SupportedMediaTypes);
Assert.True(result.Limits.Vision.MaxPromptImages > 0);
Assert.True(result.Limits.Vision.MaxPromptImageSize > 0);
}
[Theory]
[InlineData("claude-opus-4.6")]
[InlineData("claude-opus-4.5")]
[InlineData("gpt-5")]
[InlineData("gpt-5.1")]
public void GetCapabilitiesOverride_ReasoningModel_SetsReasoningEffort(string model)
{
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.NotNull(result);
Assert.NotNull(result.Supports);
Assert.True(result.Supports!.ReasoningEffort);
}
[Theory]
[InlineData("claude-haiku-4.5")]
[InlineData("gpt-5-mini")]
[InlineData("gpt-4.1")]
public void GetCapabilitiesOverride_NonVisionNonReasoning_ReturnsNull(string model)
{
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.Null(result);
}
[Fact]
public void GetCapabilitiesOverride_UnknownModel_ReturnsNull()
{
var result = ModelCapabilities.GetCapabilitiesOverride("totally-unknown-model-xyz");
Assert.Null(result);
}
[Theory]
[InlineData("gemini-3-pro")]
[InlineData("gemini-3-pro-preview")]
public void GetCapabilitiesOverride_VisionModel_AlsoSetsReasoningEffort(string model)
{
// Gemini models have both Vision and ReasoningExpert flags
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.NotNull(result);
Assert.NotNull(result.Supports);
Assert.True(result.Supports!.Vision);
Assert.True(result.Supports.ReasoningEffort);
}
[Theory]
[InlineData("claude-sonnet-4.5")]
[InlineData("claude-sonnet-4")]
public void GetCapabilitiesOverride_NonReasoningNonVision_WithToolUse_ReturnsNull(string model)
{
// Sonnet models have CodeExpert + ToolUse + Fast, but not ReasoningExpert or Vision
var result = ModelCapabilities.GetCapabilitiesOverride(model);
Assert.Null(result);
}
}