Skip to content

Commit a433d9e

Browse files
committed
Fix flake8 warnings in fs and tests modules
1 parent 70ee97a commit a433d9e

6 files changed

Lines changed: 16 additions & 19 deletions

File tree

fs/ftpfs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def writable(self):
267267
return self.mode.writing
268268

269269
def write(self, data):
270-
# type: (Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]) -> int
270+
# type: (Union[bytes, memoryview, array.array[Any], mmap.mmap]) -> int
271271
if not self.mode.writing:
272272
raise IOError("File not open for writing")
273273

@@ -289,7 +289,7 @@ def write(self, data):
289289
return data_pos
290290

291291
def writelines(self, lines):
292-
# type: (Iterable[Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]]) -> None
292+
# type: (Iterable[Union[bytes, memoryview, array.array[Any], mmap.mmap]]) -> None # noqa: E501
293293
if not self.mode.writing:
294294
raise IOError("File not open for writing")
295295
data = bytearray()

fs/info.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ def _make_datetime(self, t):
7272
# type: (None) -> None
7373
pass
7474

75-
@overload # noqa: F811
76-
def _make_datetime(self, t):
75+
@overload
76+
def _make_datetime(self, t): # noqa: F811
7777
# type: (int) -> datetime
7878
pass
7979

@@ -90,7 +90,7 @@ def get(self, namespace, key):
9090
pass
9191

9292
@overload # noqa: F811
93-
def get(self, namespace, key, default):
93+
def get(self, namespace, key, default): # noqa: F811
9494
# type: (Text, Text, T) -> Union[Any, T]
9595
pass
9696

fs/iotools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def truncate(self, size=None):
9090
return self._f.truncate(size)
9191

9292
def write(self, data):
93-
# type: (Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]) -> int
93+
# type: (Union[bytes, memoryview, array.array[Any], mmap.mmap]) -> int
9494
if isinstance(data, array.array):
9595
count = self._f.write(data.tobytes())
9696
else:
@@ -144,7 +144,7 @@ def readlines(self, hint=None):
144144
return self._f.readlines(-1 if hint is None else hint)
145145

146146
def writelines(self, lines):
147-
# type: (Iterable[Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]]) -> None
147+
# type: (Iterable[Union[bytes, memoryview, array.array[Any], mmap.mmap]]) -> None # noqa: E501
148148
_lines = (
149149
line.tobytes() if isinstance(line, array.array) else line for line in lines
150150
)

fs/memoryfs.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -193,17 +193,15 @@ def writable(self):
193193
return self._mode.writing
194194

195195
def write(self, data):
196-
# type: (Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]) -> int
196+
# type: (Union[bytes, memoryview, array.array[Any], mmap.mmap]) -> int
197197
if not self._mode.writing:
198198
raise IOError("File not open for writing")
199199
with self._seek_lock():
200200
self.on_modify()
201201
return self._bytes_io.write(data)
202202

203203
def writelines(self, sequence):
204-
# type: (Iterable[Union[bytes, bytearray, memoryview, array.array[Any], mmap.mmap]]) -> None
205-
# FIXME(@althonos): For some reason the stub for IOBase.writelines
206-
# is List[Any] ?! It should probably be Iterable[ByteString]
204+
# type: (Iterable[Union[bytes, memoryview, array.array[Any], mmap.mmap]]) -> None # noqa: E501
207205
with self._seek_lock():
208206
self.on_modify()
209207
self._bytes_io.writelines(sequence)
@@ -248,18 +246,18 @@ def size(self):
248246
_bytes_file.seek(0, os.SEEK_END)
249247
return _bytes_file.tell()
250248

251-
@overload # noqa: F811
252-
def get_entry(self, name, default):
249+
@overload
250+
def get_entry(self, name, default): # noqa: F811
253251
# type: (Text, _DirEntry) -> _DirEntry
254252
pass
255253

256-
@overload # noqa: F811
257-
def get_entry(self, name):
254+
@overload
255+
def get_entry(self, name): # noqa: F811
258256
# type: (Text) -> Optional[_DirEntry]
259257
pass
260258

261-
@overload # noqa: F811
262-
def get_entry(self, name, default):
259+
@overload
260+
def get_entry(self, name, default): # noqa: F811
263261
# type: (Text, None) -> Optional[_DirEntry]
264262
pass
265263

tests/test_appfs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from __future__ import unicode_literals
22

3-
import os
43
import shutil
54
import tempfile
65
import unittest

tests/test_ftpfs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
try:
3030
from pytest.mark import slow
31-
except:
31+
except ImportError:
3232

3333
def slow(cls):
3434
return cls

0 commit comments

Comments
 (0)