raise exc in mange_fs if fs is not writeable

Author: tfeldmann

CHANGELOG.md

@@ -19,7 +19,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   ([#527](https://github.com/PyFilesystem/pyfilesystem2/pull/527)). 
 - Optimized moving files between filesystems with syspaths.
   ([#523](https://github.com/PyFilesystem/pyfilesystem2/pull/523)).
-- Fixed `move.move_file` to clean up the copy on the destination in case of errors.
+- Fixed `fs.move.move_file` to clean up the copy on the destination in case of errors.
+- `fs.opener.manage_fs` with `writeable=True` will now raise a `ResourceReadOnly`
+  exception if the managed filesystem is not writeable.
 
 
 ## [2.4.15] - 2022-02-07

fs/move.py

@@ -71,13 +71,6 @@ def move_file(
             if _src_fs.hassyspath(src_path) and _dst_fs.hassyspath(dst_path):
                 # if both filesystems have a syspath we create a new OSFS from a
                 # common parent folder and use it to move the file.
-
-                # we have to raise ResourceReadOnly manually if a FS is read-only
-                if _src_fs.getmeta().get("read_only", True):
-                    raise ResourceReadOnly(_src_fs, src_path)
-                if _dst_fs.getmeta().get("read_only", True):
-                    raise ResourceReadOnly(_dst_fs, dst_path)
-
                 try:
                     src_syspath = _src_fs.getsyspath(src_path)
                     dst_syspath = _dst_fs.getsyspath(dst_path)
@@ -136,10 +129,10 @@ def move_dir(
     """
 
     def src():
-        return manage_fs(src_fs, writeable=False)
+        return manage_fs(src_fs, writeable=True)
 
     def dst():
-        return manage_fs(dst_fs, create=True)
+        return manage_fs(dst_fs, writeable=True, create=True)
 
     with src() as _src_fs, dst() as _dst_fs:
         with _src_fs.lock(), _dst_fs.lock():

fs/opener/registry.py

@@ -14,6 +14,7 @@
 
 from .base import Opener
 from .errors import UnsupportedProtocol, EntryPointError
+from ..errors import ResourceReadOnly
 from .parse import parse_fs_url
 
 if typing.TYPE_CHECKING:
@@ -282,10 +283,18 @@ def manage_fs(
         """
         from ..base import FS
 
+        def assert_writeable(fs):
+            if fs.getmeta().get("read_only", True):
+                raise ResourceReadOnly(path=str(fs_url))
+
         if isinstance(fs_url, FS):
+            if writeable:
+                assert_writeable(fs_url)
             yield fs_url
         else:
             _fs = self.open_fs(fs_url, create=create, writeable=writeable, cwd=cwd)
+            if writeable:
+                assert_writeable(_fs)
             try:
                 yield _fs
             finally: