refactor: extract shared V2_HEADERS constant and add FIRST_NAME test

Move the duplicated V2 API version header into a shared v2-headers.ts
module, reused by both location and ticket services. Remove unused
InputFieldType. Add test for minimal FIRST_NAME field creation.

Author: 2ndalpha

packages/javascript-api/src/lib/model/input-field/input-field-type.ts

@@ -1,6 +1,7 @@
 import * as sinon from 'sinon';
 import { Desk } from '../../model/desk';
 import { InputFieldCreationRequest } from '../../model/input-field/input-field-creation-request';
+import { FirstNameFieldCreationRequest } from '../../model/input-field/first-name-field-creation-request';
 import { NumericFieldCreationRequest } from '../../model/input-field/numeric-field-creation-request';
 import { SelectFieldCreationRequest } from '../../model/input-field/select-field-creation-request';
 import { Qminder } from '../../qminder';
@@ -329,6 +330,30 @@ describe('Location service', function () {
         }),
       ).toBeTruthy();
     });
+
+    it('sends a FIRST_NAME field with only base properties', async function () {
+      const firstNameField: FirstNameFieldCreationRequest = {
+        type: 'FIRST_NAME',
+        id: 'f6a7b8c9-d0e1-2345-faba-456789012345',
+        location: { id: LOCATION_ID },
+        isMandatoryBeforeAdded: false,
+        isMandatoryBeforeServed: false,
+        isMandatoryInRemoteSignIn: false,
+        isVisibleInWaitingDrawer: true,
+        isVisibleInServingDrawer: true,
+        visibleForLines: [],
+        showInRemoteSignIn: false,
+      };
+
+      await LocationService.createInputField(firstNameField);
+      expect(
+        requestStub.calledWith('input-fields', {
+          method: 'POST',
+          body: JSON.stringify(firstNameField),
+          headers: { 'X-Qminder-API-Version': '2020-09-01' },
+        }),
+      ).toBeTruthy();
+    });
   });
 
   afterEach(function () {

packages/javascript-api/src/lib/services/location/location.service.spec.ts

@@ -5,8 +5,7 @@ import { OpeningHours } from '../../model/opening-hours.js';
 import { OpeningHoursException } from '../../model/opening-hours-exception.js';
 import { extractId, IdOrObject } from '../../util/id-or-object.js';
 import { ApiBase } from '../api-base/api-base.js';
-
-const V2_HEADERS = { 'X-Qminder-API-Version': '2020-09-01' } as const;
+import { V2_HEADERS } from '../v2-headers.js';
 
 export function list(): Promise<Location[]> {
   return ApiBase.request('v1/locations/').then(

packages/javascript-api/src/lib/services/location/location.ts

@@ -10,6 +10,7 @@ import {
   extractIdToNumber,
 } from '../../util/id-or-object.js';
 import { ApiBase } from '../api-base/api-base.js';
+import { V2_HEADERS } from '../v2-headers.js';
 import { ResponseValidationError } from '../../model/errors/response-validation-error.js';
 import { ExternalData } from '../../model/ticket/external-data.js';
 
@@ -329,9 +330,7 @@ export async function create(
   const result: TicketCreatedResponse = await ApiBase.request('tickets', {
     method: 'POST',
     body,
-    headers: {
-      'X-Qminder-API-Version': '2020-09-01',
-    },
+    headers: V2_HEADERS,
   });
   if (!result.id) {
     throw new ResponseValidationError('Response does not contain "id"');
@@ -360,9 +359,7 @@ export async function edit(
   await ApiBase.request(`tickets/${ticketId}`, {
     method: 'PATCH',
     body,
-    headers: {
-      'X-Qminder-API-Version': '2020-09-01',
-    },
+    headers: V2_HEADERS,
   });
 }
 

packages/javascript-api/src/lib/services/ticket/ticket.ts

@@ -0,0 +1 @@
+export const V2_HEADERS = { 'X-Qminder-API-Version': '2020-09-01' } as const;

packages/javascript-api/src/lib/services/v2-headers.ts

@@ -38,7 +38,6 @@ export { InputFieldCreationRequest } from '../lib/model/input-field/input-field-
 export { InputFieldBase } from '../lib/model/input-field/input-field-base.js';
 export { LocationRef } from '../lib/model/input-field/location-ref.js';
 export { LineRef } from '../lib/model/input-field/line-ref.js';
-export { InputFieldType } from '../lib/model/input-field/input-field-type.js';
 export { InputFieldTranslation } from '../lib/model/input-field/input-field-translation.js';
 export { SelectOption } from '../lib/model/input-field/select-option.js';
 export { SelectOptionTranslation } from '../lib/model/input-field/select-option-translation.js';