Skip to content

Commit c4bc6d7

Browse files
committed
ran flake8 for CI
1 parent a6a5722 commit c4bc6d7

6 files changed

Lines changed: 5 additions & 8 deletions

File tree

package/cloudshell/iac/terraform/downloaders/base_git_downloader.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,3 @@ def download_repo(self, url: str, token: str, branch: str = "") -> str:
1717
4. return full path of working dir as string
1818
"""
1919
pass
20-

package/cloudshell/iac/terraform/services/local_dir_service.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from cloudshell.iac.terraform.constants import ATTRIBUTE_NAMES
1010

1111

12-
1312
def handle_remove_readonly(func, path, exc_info):
1413
"""
1514
Error handler for ``shutil.rmtree``.
@@ -51,8 +50,8 @@ def delete_local_temp_dir(sandbox_data_handler: SandboxDataHandler, tf_working_d
5150
sandbox_data_handler.set_tf_working_dir("")
5251

5352
@staticmethod
54-
def does_working_dir_exists(dir: str) -> bool:
55-
return dir and os.path.isdir(dir)
53+
def does_working_dir_exists(working_dir: str) -> bool:
54+
return working_dir and os.path.isdir(working_dir)
5655

5756
@staticmethod
5857
def prepare_tf_working_dir(logger: logging.Logger, sandbox_data_handler: SandboxDataHandler,

package/tests/integration_tests/helper_objects/env_vars.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ def __init__(self):
2020
self.api_url = os.environ.get("GITLAB_TF_API_URL")
2121
self.natural_url = os.environ.get("GITLAB_TF_NATURAL_URL")
2222
self.token = os.environ.get("GITLAB_TOKEN")
23-
self.branch = os.environ.get("GITLAB_BRANCH")
23+
self.branch = os.environ.get("GITLAB_BRANCH")

package/tests/integration_tests/helper_objects/stdout_logger.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ def get_test_logger(log_level: str = logging.DEBUG):
1919
formatter = logging.Formatter(fmt=LOG_FORMAT, datefmt=LOG_DATE_FORMAT)
2020
handler.setFormatter(formatter)
2121
logger.addHandler(handler)
22-
return logger
22+
return logger

package/tests/unit_tests/test_gitlab_url_extractor.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,3 @@ def test_raises(self):
2222
url_arg = ""
2323
self.assertRaises(ValueError, gitlab_downloader.extract_data_from_api_url, url_arg)
2424
self.assertRaises(ValueError, gitlab_downloader.extract_data_from_natural_url, url_arg)
25-
26-

run_flake8.bat

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
python -m flake8 . --count --ignore=E722,W605,E501,F841 --exclude=*__init__.py,*tag_terraform_resources.py,*data_model.py --statistics --show-source

0 commit comments

Comments
 (0)