fixed other bug in the plugin dice roll engine

R-Rudolph · R-Rudolph · commit 537ee141f865 · 2019-02-10T05:53:18.000+01:00
diff --git a/core/client/util/dicerollentry.cpp b/core/client/util/dicerollentry.cpp
@@ -67,8 +67,10 @@ DiceRollResult DiceRollEntry::roll(bool signOnPositive) const
     int sum = 0;
     for(int i=0;i<numDice_;i++)
     {
-      int rolledValue = static_cast<int>(Dice::roll(value_));
-      rollList.append(QString::number(rolledValue));
+      int rolledValue = static_cast<int>(Dice::roll(std::abs(value_)));
+      if(value_ < 0)
+        rolledValue = - rolledValue;
+      rollList.append(QString::number(std::abs(rolledValue)));
       sum += rolledValue;
     }
     text += rollList.join(',');

Original file line number	Diff line number	Diff line change
`@@ -67,8 +67,10 @@ DiceRollResult DiceRollEntry::roll(bool signOnPositive) const`
`67`	`67`	`int sum = 0;`
`68`	`68`	`for(int i=0;i<numDice_;i++)`
`69`	`69`	`{`
`70`		`- int rolledValue = static_cast<int>(Dice::roll(value_));`
`71`		`- rollList.append(QString::number(rolledValue));`
	`70`	`+ int rolledValue = static_cast<int>(Dice::roll(std::abs(value_)));`
	`71`	`+ if(value_ < 0)`
	`72`	`+ rolledValue = - rolledValue;`
	`73`	`+ rollList.append(QString::number(std::abs(rolledValue)));`
`72`	`74`	`sum += rolledValue;`
`73`	`75`	`}`
`74`	`76`	`text += rollList.join(',');`