From 2697466828c0d44ad7f125647a265afe1734e12b Mon Sep 17 00:00:00 2001 From: Dan Palermo Date: Thu, 30 Apr 2026 18:31:30 -0500 Subject: [PATCH 1/2] [lint] Use git diff to get file lists - Avoid issue with separator: '\n' on changed-files action not actually generating a newline character --- .github/workflows/aomp-shell.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/aomp-shell.yml b/.github/workflows/aomp-shell.yml index 3878282e2..3bee6970f 100644 --- a/.github/workflows/aomp-shell.yml +++ b/.github/workflows/aomp-shell.yml @@ -17,7 +17,7 @@ jobs: id: changed-files uses: tj-actions/changed-files@22103cc46bda19c2b464ffe86db46df6922fd323 with: - separator: '\n' + separator: ' ' skip_initial_fetch: true base_sha: 'HEAD~1' sha: 'HEAD' @@ -25,6 +25,7 @@ jobs: - name: Echo changed files run: | echo "Changed files: ${{ steps.changed-files.outputs.all_changed_files }}" + echo "Git diff files: $(git diff --name-only HEAD~1 HEAD) - name: Run shellcheck run: | @@ -43,6 +44,6 @@ jobs: popd || exit 1 fi - done <<< "${{ steps.changed-files.outputs.all_changed_files }}" + done <<< $(git diff --name-only HEAD~1 HEAD) exit $shellcheck_status shell: bash {0} From 4d667da2b7872e72685847aaac234379339a006b Mon Sep 17 00:00:00 2001 From: Dan Palermo Date: Thu, 30 Apr 2026 18:37:35 -0500 Subject: [PATCH 2/2] Fix missing trailing quote --- .github/workflows/aomp-shell.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/aomp-shell.yml b/.github/workflows/aomp-shell.yml index 3bee6970f..1f43fdf20 100644 --- a/.github/workflows/aomp-shell.yml +++ b/.github/workflows/aomp-shell.yml @@ -25,7 +25,7 @@ jobs: - name: Echo changed files run: | echo "Changed files: ${{ steps.changed-files.outputs.all_changed_files }}" - echo "Git diff files: $(git diff --name-only HEAD~1 HEAD) + echo "Git diff files: $(git diff --name-only HEAD~1 HEAD)" - name: Run shellcheck run: |