feat: provide (un)installer with failure exit code

- exit InstallCommand/UninstallCommand with exit code 1 on detected
  command failures or thrown exceptions; log where appropriate
- fixes #362

Author: laur89

src/main/kotlin/app/revanced/cli/command/utility/InstallCommand.kt

@@ -7,6 +7,7 @@ import kotlinx.coroutines.runBlocking
 import picocli.CommandLine.*
 import java.io.File
 import java.util.logging.Logger
+import kotlin.system.exitProcess
 
 @Command(
     name = "install",
@@ -30,7 +31,7 @@ internal object InstallCommand : Runnable {
 
     @Option(
         names = ["-m", "--mount"],
-        description = ["Mount the supplied APK file over the app with the supplied package name."],
+        description = ["Mount the supplied APK file over the app with the given package name."],
     )
     private var packageName: String? = null
 
@@ -44,24 +45,35 @@ internal object InstallCommand : Runnable {
                 }.install(Installer.Apk(apk, packageName))
             } catch (e: Exception) {
                 logger.severe(e.toString())
-                return
+                throw e
             }
 
             when (result) {
                 RootInstallerResult.SUCCESS ->
                     logger.info("Mounted the APK file")
-                RootInstallerResult.FAILURE ->
+                RootInstallerResult.FAILURE -> {
                     logger.severe("Failed to mount the APK file")
+                    throw Exception()
+                }
                 AdbInstallerResult.Success ->
                     logger.info("Installed the APK file")
-                is AdbInstallerResult.Failure ->
+                is AdbInstallerResult.Failure -> {
                     logger.severe(result.exception.toString())
-                else -> logger.severe("Unknown installation result")
+                    throw Exception()
+                }
+                else -> {
+                    logger.severe("Unknown installation result")
+                    throw Exception()
+                }
             }
         }
 
         runBlocking {
-            deviceSerials?.map { async { install(it) } }?.awaitAll() ?: install()
+            try {
+                deviceSerials?.map { async { install(it) } }?.awaitAll() ?: install()
+            } catch (_: Exception) {
+                exitProcess(1)
+            }
         }
     }
 }

src/main/kotlin/app/revanced/cli/command/utility/UninstallCommand.kt

@@ -10,6 +10,7 @@ import kotlinx.coroutines.runBlocking
 import picocli.CommandLine.*
 import picocli.CommandLine.Help.Visibility.ALWAYS
 import java.util.logging.Logger
+import kotlin.system.exitProcess
 
 @Command(
     name = "uninstall",
@@ -48,24 +49,35 @@ internal object UninstallCommand : Runnable {
                 }.uninstall(packageName)
             } catch (e: Exception) {
                 logger.severe(e.toString())
-                return
+                throw e
             }
 
             when (result) {
                 RootInstallerResult.SUCCESS ->
                     logger.info("Unmounted the patched APK file")
-                RootInstallerResult.FAILURE ->
+                RootInstallerResult.FAILURE -> {
                     logger.severe("Failed to unmount the patched APK file")
+                    throw Exception()
+                }
                 AdbInstallerResult.Success ->
                     logger.info("Uninstalled the patched APK file")
-                is AdbInstallerResult.Failure ->
+                is AdbInstallerResult.Failure -> {
                     logger.severe(result.exception.toString())
-                else -> logger.severe("Unknown uninstallation result")
+                    throw Exception()
+                }
+                else ->  {
+                    logger.severe("Unknown uninstallation result")
+                    throw Exception()
+                }
             }
         }
 
         runBlocking {
-            deviceSerials?.map { async { uninstall(it) } }?.awaitAll() ?: uninstall()
+            try {
+                deviceSerials?.map { async { uninstall(it) } }?.awaitAll() ?: uninstall()
+            } catch (_: Exception) {
+                exitProcess(1)
+            }
         }
     }
 }