Update workflows

Author: rawandahmad698

.github/workflows/ci.yml

@@ -7,9 +7,6 @@ on:
     branches: [ main ]
   workflow_dispatch:
 
-env:
-  DEVELOPER_DIR: /Applications/Xcode_16.0.app/Contents/Developer
-
 jobs:
   lint:
     name: SwiftLint
@@ -146,9 +143,7 @@ jobs:
         xcode-version: '16.0'
 
     - name: Build to Generate Mocks
-      run: |
-        cd Recap
-        swift build
+      run: swift build
 
     - name: Check for Uncommitted Mock Changes
       run: |

.github/workflows/pr-tests.yml

@@ -4,18 +4,14 @@ on:
   pull_request:
     types: [opened, synchronize, reopened]
 
+permissions:
+  contents: read
+  pull-requests: write
+
 jobs:
-  test-matrix:
-    name: Test on macOS ${{ matrix.macos }}
-    runs-on: ${{ matrix.macos }}
-    strategy:
-      fail-fast: false
-      matrix:
-        macos: [macos-14, macos-15]
-        xcode: ['15.4', '16.0']
-        exclude:
-          - macos: macos-14
-            xcode: '16.0'
+  test:
+    name: Test PR
+    runs-on: macos-latest
 
     steps:
     - name: Checkout code
@@ -24,37 +20,39 @@ jobs:
     - name: Setup Xcode
       uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: ${{ matrix.xcode }}
+        xcode-version: latest-stable
 
     - name: Cache Dependencies
       uses: actions/cache@v4
       with:
         path: |
           ~/Library/Developer/Xcode/DerivedData
           .build
-        key: ${{ runner.os }}-${{ matrix.macos }}-spm-${{ hashFiles('**/Package.resolved') }}
+        key: ${{ runner.os }}-spm-${{ hashFiles('**/Package.resolved') }}
+        restore-keys: |
+          ${{ runner.os }}-spm-
     
     - name: Build and Test
-      run: |
-        cd Recap
-        swift test --parallel
+      run: swift test --parallel
 
     - name: Comment PR on Failure
-      if: failure()
+      if: failure() && github.event_name == 'pull_request'
       uses: actions/github-script@v7
       with:
+        github-token: ${{secrets.GITHUB_TOKEN}}
         script: |
           github.rest.issues.createComment({
             issue_number: context.issue.number,
             owner: context.repo.owner,
             repo: context.repo.repo,
-            body: '❌ Tests failed on ${{ matrix.macos }} with Xcode ${{ matrix.xcode }}. Please check the workflow logs.'
+            body: '❌ Tests failed. Please check the [workflow logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}).'
           })
     
     - name: Comment PR on Success
-      if: success() && matrix.macos == 'macos-15' && matrix.xcode == '16.0'
+      if: success() && github.event_name == 'pull_request'
       uses: actions/github-script@v7
       with:
+        github-token: ${{secrets.GITHUB_TOKEN}}
         script: |
           github.rest.issues.createComment({
             issue_number: context.issue.number,

.github/workflows/test.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   test:
     name: Run Tests
-    runs-on: macos-15
+    runs-on: macos-latest
 
     steps:
     - name: Checkout code
@@ -19,7 +19,7 @@ jobs:
     - name: Setup Xcode
       uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: '16.0'
+        xcode-version: latest-stable
 
     - name: Cache Swift Package Manager
       uses: actions/cache@v4
@@ -32,38 +32,32 @@ jobs:
           ${{ runner.os }}-spm-
     
     - name: Resolve Dependencies
-      run: |
-        cd Recap
-        swift package resolve
+      run: swift package resolve
 
     - name: Build for Testing
-      run: |
-        cd Recap
-        swift build --build-tests
+      run: swift build --build-tests
 
     - name: Run Tests
-      run: |
-        cd Recap
-        swift test --parallel --xunit-output=test-results.xml
+      run: swift test --parallel --xunit-output=test-results.xml
 
     - name: Upload Test Results
       uses: actions/upload-artifact@v4
       if: always()
       with:
         name: test-results
-        path: Recap/test-results.xml
+        path: test-results.xml
 
     - name: Publish Test Report
       uses: mikepenz/action-junit-report@v4
       if: always()
       with:
-        report_paths: 'Recap/test-results.xml'
+        report_paths: 'test-results.xml'
         check_name: 'Test Results'
         fail_on_failure: true
 
   code-coverage:
     name: Code Coverage
-    runs-on: macos-15
+    runs-on: macos-latest
 
     steps:
     - name: Checkout code
@@ -72,16 +66,13 @@ jobs:
     - name: Setup Xcode
       uses: maxim-lobanov/setup-xcode@v1
       with:
-        xcode-version: '16.0'
+        xcode-version: latest-stable
 
     - name: Generate Coverage Report
-      run: |
-        cd Recap
-        swift test --enable-code-coverage
+      run: swift test --enable-code-coverage
 
     - name: Convert Coverage to LCOV
       run: |
-        cd Recap
         xcrun llvm-cov export \
           .build/debug/RecapPackageTests.xctest/Contents/MacOS/RecapPackageTests \
           -instr-profile .build/debug/codecov/default.profdata \
@@ -92,7 +83,7 @@ jobs:
     - name: Upload Coverage to Codecov
       uses: codecov/codecov-action@v5
       with:
-        file: ./Recap/coverage.lcov
+        file: ./coverage.lcov
         flags: unittests
         name: recap-coverage
         fail_ci_if_error: false

Recap/Services/MeetingDetection/Core/MeetingDetectionService.swift

@@ -63,8 +63,8 @@ final class MeetingDetectionService: MeetingDetectionServiceType {
     }
 
     func stopMonitoring() {
-        isMonitoring = false
         monitoringTask?.cancel()
+        isMonitoring = false
         monitoringTask = nil
         isMeetingActive = false
         activeMeetingInfo = nil