fix: recording the system audio at last

Author: Ivo Bellin Salarin

Recap/Audio/Processing/AudioRecordingCoordinator/AudioRecordingCoordinator.swift

@@ -11,7 +11,7 @@ final class AudioRecordingCoordinator: AudioRecordingCoordinatorType {
     private let systemWideTap: SystemWideTap?
 
     private var isRunning = false
-    private var tapRecorder: AudioTapRecorderType?
+    private var tapRecorder: (any AudioTapRecorderType)?
 
     init(
         configuration: RecordingConfiguration,

Recap/Frameworks/Toast/AlertToast.swift

@@ -735,7 +735,9 @@ public extension View{
 
     @ViewBuilder fileprivate func valueChanged<T: Equatable>(value: T, onChange: @escaping (T) -> Void) -> some View {
         if #available(iOS 14.0, *) {
-            self.onChange(of: value, perform: onChange)
+            self.onChange(of: value) { oldValue, newValue in
+                onChange(newValue)
+            }
         } else {
             self.onReceive(Just(value)) { (value) in
                 onChange(value)

Recap/MenuBar/Dropdowns/DropdownWindowManager.swift

@@ -65,8 +65,10 @@ final class DropdownWindowManager: ObservableObject {
         guard let window = dropdownWindow else { return }
 
         animateDropdownOut(window: window) {
-            window.orderOut(nil)
-            self.dropdownWindow = nil
+            Task { @MainActor in
+                window.orderOut(nil)
+                self.dropdownWindow = nil
+            }
         }
 
         if let monitor = globalMonitor {
@@ -95,7 +97,7 @@ final class DropdownWindowManager: ObservableObject {
         }
     }
 
-    private func animateDropdownOut(window: NSWindow, completion: @escaping () -> Void) {
+    private func animateDropdownOut(window: NSWindow, completion: @Sendable @escaping () -> Void) {
         NSAnimationContext.runAnimationGroup({ context in
             context.duration = 0.2
             context.timingFunction = CAMediaTimingFunction(name: .easeIn)

Recap/Services/Processing/SystemLifecycle/SystemLifecycleManager.swift

@@ -7,6 +7,7 @@ protocol SystemLifecycleDelegate: AnyObject {
     func systemDidWake()
 }
 
+@MainActor
 final class SystemLifecycleManager {
     weak var delegate: SystemLifecycleDelegate?
 
@@ -26,15 +27,19 @@ final class SystemLifecycleManager {
             object: nil,
             queue: .main
         ) { [weak self] _ in
-            self?.delegate?.systemWillSleep()
+            Task { @MainActor in
+                self?.delegate?.systemWillSleep()
+            }
         }
 
         wakeObserver = notificationCenter.addObserver(
             forName: NSWorkspace.didWakeNotification,
             object: nil,
             queue: .main
         ) { [weak self] _ in
-            self?.delegate?.systemDidWake()
+            Task { @MainActor in
+                self?.delegate?.systemDidWake()
+            }
         }
     }
 

Recap/UIComponents/Buttons/DownloadPillButton.swift

@@ -61,7 +61,7 @@ struct DownloadPillButton: View {
                 iconOffset = 3
             }
         }
-        .onChange(of: isDownloading) { _, newValue in
+        .onChange(of: isDownloading) { oldValue, newValue in
             if newValue {
                 iconOffset = 3
             } else {

Recap/UseCases/Settings/Components/MeetingDetection/MeetingDetectionView.swift

@@ -76,7 +76,7 @@ struct MeetingDetectionView<ViewModel: MeetingDetectionSettingsViewModelType>: V
                 await viewModel.checkPermissionStatus()
             }
         }
-        .onChange(of: viewModel.autoDetectMeetings) { enabled in
+        .onChange(of: viewModel.autoDetectMeetings) { oldValue, enabled in
             if enabled {
                 Task {
                     await viewModel.checkPermissionStatus()

Recap/UseCases/Settings/Components/Reusable/CustomDropdown.swift

@@ -39,7 +39,7 @@ struct CustomDropdown<T: Hashable>: View {
                     .frame(width: 285)
                     .frame(maxHeight: showSearch ? 350 : 300)
             }
-            .onChange(of: isExpanded) { _, expanded in
+            .onChange(of: isExpanded) { oldValue, expanded in
                 if !expanded {
                     searchText = ""
                 }

Recap/UseCases/Settings/Components/Reusable/CustomTextEditor.swift

@@ -65,7 +65,7 @@ struct CustomTextEditor: View {
                     .focused($isFocused)
                     .lineLimit(nil)
                     .textSelection(.enabled)
-                    .onChange(of: isFocused) { _, focused in
+                    .onChange(of: isFocused) { oldValue, focused in
                         withAnimation(.easeInOut(duration: 0.2)) {
                             isEditing = focused
                         }