Skip to content

Commit 41da381

Browse files
authored
Merge pull request #25 from RefactorSecurity/avoid-persistence-no-notes
Avoid creating persistence file if no notes
2 parents c7b45ac + 00e21e3 commit 41da381

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"displayName": "Security Notes",
44
"description": "Create notes during a security code review. Import your favorite SAST tool results and collaborate with others.",
55
"icon": "resources/security_notes_logo.png",
6-
"version": "1.3.0",
6+
"version": "1.3.1",
77
"publisher": "refactor-security",
88
"private": false,
99
"license": "MIT",

src/persistence/local-db/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ import { getLocalDbFilePath } from '../../utils';
99
const persistenceFile = getLocalDbFilePath();
1010

1111
export const saveNotesToFile = (noteMap: Map<string, CommentThread>) => {
12+
// Avoid creating persistence file if no notes were created
13+
if (!fs.existsSync(persistenceFile) && !noteMap.size) {
14+
return;
15+
}
1216
fs.writeFileSync(persistenceFile, JSON.stringify(Serializer.serialize(noteMap)));
1317
};
1418

0 commit comments

Comments
 (0)