MNT: address third round of PR review comments

- Guard from_rpy against non-dict JSON payloads (e.g. [] or "foo")
  that would AttributeError instead of hitting the 422 path
- Change notebook to resimulate=True so flight.all_info() has
  computed outputs available after loading an .rpy with
  include_outputs=False

Made-with: Cursor

Author: GabrielBarberini

src/services/flight.py

@@ -91,6 +91,8 @@ def from_rpy(cls, content: bytes) -> Self:
                         or does not contain a Flight.
         """
         data = json.loads(content)
+        if not isinstance(data, dict):
+            raise ValueError("File does not contain a valid .rpy JSON object")
         simulation = data.get("simulation", data)
         flight = json.loads(
             json.dumps(simulation),
@@ -535,7 +537,7 @@ def generate_notebook(flight_id: str) -> dict:
                 "source": [
                     "flight = load_from_rpy("
                     f'"{rpy_filename}", '
-                    "resimulate=False)\n",
+                    "resimulate=True)\n",
                     "\n",
                     "flight.all_info()",
                 ],