fix: remove the option to flag as VLQ

Author: double-beep

src/AdvancedFlagging.ts

@@ -1,12 +1,11 @@
 import Post from './UserscriptTools/Post';
 import Page from './UserscriptTools/Page';
 
-import { Flags } from './FlagTypes';
 import { setupConfiguration } from './Configuration';
 import { Popover } from './popover';
 
 import { setupReview } from './review';
-import { addXHRListener, FlagNames, interceptXhr, popupDelay } from './shared';
+import { addXHRListener, interceptXhr, popupDelay } from './shared';
 
 import { NattyAPI } from './UserscriptTools/NattyApi';
 import { MetaSmokeAPI } from './UserscriptTools/MetaSmokeAPI';
@@ -72,20 +71,6 @@ popupWrapper.id = 'advanced-flagging-snackbar';
 
 document.body.append(popupWrapper);
 
-export function getFlagToRaise(
-    flagName: Flags,
-    qualifiesForVlq: boolean
-): Flags {
-    const vlqFlag = FlagNames.VLQ;
-    const naaFlag = FlagNames.NAA;
-
-    // If the flag name is VLQ, check if the criteria are met.
-    // If not, switch to NAA
-    return flagName === vlqFlag
-        ? (qualifiesForVlq ? vlqFlag : naaFlag)
-        : flagName;
-}
-
 export function displayToaster(
     text: string,
     state: 'success' | 'danger'

src/Configuration.ts

@@ -132,6 +132,16 @@ function setupDefaults(): void {
 
         Store.updateConfiguration();
     }
+
+    // https://meta.stackoverflow.com/a/434697
+    Store.flagTypes
+        // @ts-expect-error VLQ flag is removed, see the link above
+        .filter(({ reportType }) => reportType === 'PostLowQuality')
+        .forEach(flagType => {
+            flagType.reportType = FlagNames.NAA;
+        });
+
+    Store.updateFlagTypes();
 }
 
 export function setupConfiguration(): void {

src/FlagTypes.ts

@@ -6,7 +6,6 @@ export type Flags = 'AnswerNotAnAnswer'
     | 'PostSpam'
     | 'NoFlag'
     | 'PostOther'
-    | 'PostLowQuality'
     | 'PlagiarizedContent';
 
 const deletedAnswers = '/help/deleted-answers';
@@ -111,7 +110,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 6,
                 displayName: 'Link Only',
-                reportType: FlagNames.VLQ,
+                reportType: FlagNames.NAA,
                 comments: {
                     // comment by Yunnosch: https://chat.stackoverflow.com/transcript/message/57442309
                     low: 'A link to a solution is welcome, but please ensure your answer is useful without it: '
@@ -179,7 +178,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 10,
                 displayName: 'Library',
-                reportType: FlagNames.VLQ,
+                reportType: FlagNames.NAA,
                 comments: {
                     low: 'Please don\'t just post some tool or library as an answer. At least demonstrate '
                        + '[how it solves the problem](//meta.stackoverflow.com/a/251605) in the answer itself.',
@@ -214,7 +213,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 13,
                 displayName: 'Non English',
-                reportType: FlagNames.VLQ,
+                reportType: FlagNames.NAA,
                 comments: {
                     low: 'Please write your answer in English, as Stack Overflow is an '
                        + '[English-only site](//meta.stackoverflow.com/a/297680).',

src/UserscriptTools/NattyApi.ts

@@ -114,7 +114,7 @@ export class NattyAPI extends Reporter {
         if (!this.canBeReported()) return '';
 
         // Handle cases where the post may not be reported to Natty on time:
-        // - when a mod flags a post as NAA/VLQ it is deleted immediately.
+        // - when a mod flags a post as NAA it is deleted immediately.
         // - when a reviewer sends the last Recommend deletion/Delete review,
         //   the post is also deleted immediately
         // - if a red flag has been raised by the user

src/UserscriptTools/Post.ts

@@ -1,4 +1,4 @@
-import { getFlagToRaise, page } from '../AdvancedFlagging';
+import { page } from '../AdvancedFlagging';
 import { Flags } from '../FlagTypes';
 import {
     PostType,
@@ -110,12 +110,9 @@ export default class Post {
     }
 
     public async flag(
-        reportType: Flags,
+        flagName: Flags,
         text: string | null,
     ): Promise<void> {
-        // if the flag name is VLQ, then we need to check if the criteria are met.
-        // If not, switch to NAA
-        const flagName = getFlagToRaise(reportType, this.qualifiesForVlq());
         const targetUrl = this.reporters.Guttenberg?.targetUrl;
 
         const url = `/flags/posts/${this.id}/add/${flagName}`;
@@ -427,14 +424,6 @@ export default class Post {
         );
     }
 
-    public qualifiesForVlq(): boolean {
-        const dayMillis = 1000 * 60 * 60 * 24;
-
-        // a post can't be flagged as VLQ if it has a positive score
-        // or is more than 1 day old
-        return (new Date().valueOf() - this.date.valueOf()) < dayMillis && this.score <= 0;
-    }
-
     // returns [bot name, checkbox config]
     public getFeedbackBoxes(isFlagOrReview = false): ReporterBoxes {
         type ReportersEntries = [

src/popover.ts

@@ -10,7 +10,6 @@ import {
     delay,
     configBoxes
 } from './shared';
-import { getFlagToRaise } from './AdvancedFlagging';
 import Post from './UserscriptTools/Post';
 
 import { Menu, Spinner } from '@userscripters/stacks-helpers';
@@ -209,7 +208,7 @@ export class Popover {
     ): string {
         /*
         Example innerText:
-            Flag: as VLQ
+            Flag: as NAA
             Comment: Please write your answer in English, as Stack Overflow
                      is an [English-only site](//meta.stackoverflow.com/a/297680).
             Feedbacks: tp to Natty, track with Generic Bot
@@ -235,17 +234,10 @@ export class Popover {
         const commentText = this.getCommentText(flagType);
         const tooltipCommentText = (this.post.deleted ? '' : commentText) || '';
 
-        // if the flag changed from VLQ to NAA, let the user know why
-        const flagName = getFlagToRaise(reportType, this.post.qualifiesForVlq());
-
-        let reportTypeHuman = reportType === 'NoFlag' || !this.post.deleted
-            ? getHumanFromDisplayName(flagName)
+        const reportTypeHuman = reportType === 'NoFlag' || !this.post.deleted
+            ? getHumanFromDisplayName(reportType)
             : '';
 
-        if (reportType !== flagName) {
-            reportTypeHuman += ' (VLQ criteria aren\'t met)';
-        }
-
         // ---------------------------------------------------
 
         const popoverParent = document.createElement('div');

src/shared.ts

@@ -36,7 +36,6 @@ export enum FlagNames {
     Spam = 'PostSpam',
     Rude = 'PostOffensive',
     NAA = 'AnswerNotAnAnswer',
-    VLQ = 'PostLowQuality',
     NoFlag = 'NoFlag',
     Plagiarism = 'PlagiarizedContent',
     ModFlag = 'PostOther'
@@ -167,7 +166,6 @@ export type HumanFlags = 'as NAA'
     | 'as R/A'
     | 'as spam'
     | 'for plagiarism'
-    | 'as VLQ'
     | 'for moderator attention'
     | '';
 
@@ -176,7 +174,6 @@ export function getHumanFromDisplayName(displayName: Flags): HumanFlags {
         [FlagNames.Spam]: 'as spam',
         [FlagNames.Rude]: 'as R/A',
         [FlagNames.NAA]: 'as NAA',
-        [FlagNames.VLQ]: 'as VLQ',
         [FlagNames.NoFlag]: '',
         [FlagNames.Plagiarism]: 'for plagiarism',
         [FlagNames.ModFlag]: 'for moderator attention',