chore(vscode): clean up format and improve logs

Author: benfdking

vscode/extension/src/commands/format.ts

@@ -1,5 +1,4 @@
 import { traceLog } from '../utilities/common/log'
-import { execSync } from 'child_process'
 import { sqlmeshExec } from '../utilities/sqlmesh/sqlmesh'
 import { err, isErr, ok, Result } from '@bus/result'
 import * as vscode from 'vscode'
@@ -10,6 +9,7 @@ import {
   handleSqlmeshLspDependenciesMissingError,
 } from '../utilities/errors'
 import { AuthenticationProviderTobikoCloud } from '../auth/auth'
+import { execAsync } from '../utilities/exec'
 
 export const format =
   (authProvider: AuthenticationProviderTobikoCloud) =>
@@ -37,22 +37,20 @@ export const format =
     vscode.window.showInformationMessage('Project formatted successfully')
   }
 
-const internalFormat = async (): Promise<Result<number, ErrorType>> => {
-  try {
-    const exec = await sqlmeshExec()
-    if (isErr(exec)) {
-      return exec
-    }
-    execSync(`${exec.value.bin} format`, {
-      encoding: 'utf-8',
-      cwd: exec.value.workspacePath,
-      env: exec.value.env,
-    })
-    return ok(0)
-  } catch (error: any) {
+const internalFormat = async (): Promise<Result<undefined, ErrorType>> => {
+  const exec = await sqlmeshExec()
+  if (isErr(exec)) {
+    return exec
+  }
+  const result = await execAsync(`${exec.value.bin}`, ['format'], {
+    cwd: exec.value.workspacePath,
+    env: exec.value.env,
+  })
+  if (result.exitCode !== 0) {
     return err({
       type: 'generic',
-      message: `Error executing sqlmesh format: ${error.message}`,
+      message: `Error executing sqlmesh format: ${result.stderr}`,
     })
   }
+  return ok(undefined)
 }

vscode/extension/src/utilities/exec.ts

@@ -12,14 +12,26 @@ export interface CancellableExecOptions extends ExecOptions {
   signal?: AbortSignal
 }
 
-export function execAsync(
+export async function execAsync(
+  command: string,
+  args: string[],
+  options: CancellableExecOptions = {},
+): Promise<ExecResult> {
+  traceInfo(`Executing command: ${command} ${args.join(' ')}`)
+  const result = await execAsyncCore(command, args, options)
+  traceInfo(
+    `Command ${command} ${args.join(' ')} exited with code ${result.exitCode} and stdout ${result.stdout} and stderr ${result.stderr}`,
+  )
+  return result
+}
+
+function execAsyncCore(
   command: string,
   args: string[],
   options: CancellableExecOptions = {},
 ): Promise<ExecResult> {
   return new Promise((resolve, reject) => {
     // Pass the signal straight through to `exec`
-    traceInfo(`Executing command: ${command} ${args.join(' ')}`)
     const child = exec(
       `${command} ${args.join(' ')}`,
       options,