Fix reporting of demoted view names in the plan explainer

Author: izeigerman

sqlmesh/core/plan/explainer.py

@@ -227,7 +227,7 @@ def visit_virtual_layer_update_stage(self, stage: stages.VirtualLayerUpdateStage
             "[bold]Delete views in the virtual layer for models that were removed[/bold]"
         )
         for snapshot in stage.demoted_snapshots:
-            display_name = self._display_name(snapshot)
+            display_name = self._display_name(snapshot, stage.demoted_environment_naming_info)
             demote_tree.add(display_name)
 
         if stage.promoted_snapshots:
@@ -254,9 +254,13 @@ def visit_finalize_environment_stage(
     ) -> t.Optional[Tree]:
         return None
 
-    def _display_name(self, snapshot: SnapshotInfoMixin) -> str:
+    def _display_name(
+        self,
+        snapshot: SnapshotInfoMixin,
+        environment_naming_info: t.Optional[EnvironmentNamingInfo] = None,
+    ) -> str:
         return snapshot.display_name(
-            self.environment_naming_info,
+            environment_naming_info or self.environment_naming_info,
             self.default_catalog if self.verbosity < Verbosity.VERY_VERBOSE else None,
             dialect=self.dialect,
         )

tests/conftest.py

@@ -257,6 +257,7 @@ def push_plan(context: Context, plan: Plan) -> None:
         context.create_scheduler,
         context.default_catalog,
     )
+    deployability_index = DeployabilityIndex.create(context.snapshots.values())
     evaluatable_plan = plan.to_evaluatable()
     stages = plan_stages.build_plan_stages(
         evaluatable_plan, context.state_sync, context.default_catalog
@@ -265,12 +266,12 @@ def push_plan(context: Context, plan: Plan) -> None:
         if isinstance(stage, plan_stages.CreateSnapshotRecordsStage):
             plan_evaluator.visit_create_snapshot_records_stage(stage, evaluatable_plan)
         elif isinstance(stage, plan_stages.PhysicalLayerUpdateStage):
-            stage.deployability_index = DeployabilityIndex.all_deployable()
+            stage.deployability_index = deployability_index
             plan_evaluator.visit_physical_layer_update_stage(stage, evaluatable_plan)
         elif isinstance(stage, plan_stages.EnvironmentRecordUpdateStage):
             plan_evaluator.visit_environment_record_update_stage(stage, evaluatable_plan)
         elif isinstance(stage, plan_stages.VirtualLayerUpdateStage):
-            stage.deployability_index = DeployabilityIndex.all_deployable()
+            stage.deployability_index = deployability_index
             plan_evaluator.visit_virtual_layer_update_stage(stage, evaluatable_plan)
         elif isinstance(stage, plan_stages.FinalizeEnvironmentStage):
             plan_evaluator.visit_finalize_environment_stage(stage, evaluatable_plan)