fix(vscode): further simplify path handling

Author: benfdking

sqlmesh/lsp/uri.py

@@ -24,10 +24,12 @@ def __repr__(self) -> str:
 
     def to_path(self) -> Path:
         p = to_fs_path(self.value)
-        return Path(p)
+        unencoded_path = p.replace("%3A", ":")
+        return Path(unencoded_path)
 
     @staticmethod
     def from_path(path: t.Union[str, Path]) -> "URI":
         if isinstance(path, Path):
-            path = path.as_posix()
-        return URI(from_fs_path(path))
+            path = str(path)
+        encoded_path = path.replace(":", "%3A")
+        return URI(from_fs_path(encoded_path))

tests/lsp/test_context.py

@@ -20,3 +20,10 @@ def test_lsp_context():
     # Check that the value is a ModelInfo with the expected model name
     assert isinstance(lsp_context.map[active_customers_key], ModelTarget)
     assert "sushi.active_customers" in lsp_context.map[active_customers_key].names
+
+    # Check that all the values in the map are normalised
+    keys = lsp_context.map.keys()
+    for key in keys:
+        stripped_key_from_prefix = str(key).split("file://")[1]
+        assert ":" not in stripped_key_from_prefix
+        assert "\\" not in stripped_key_from_prefix