Skip to content

Commit f4cfae0

Browse files
committed
update filesystems config to be consistent with dbt convention
1 parent 0c3e751 commit f4cfae0

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

docs/integrations/engines/duckdb.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,14 +279,13 @@ The `filesystems` accepts a list of file systems to register in the DuckDB conne
279279
extensions:
280280
- ducklake
281281
filesystems:
282-
- protocol: abfs
283-
storage_options:
284-
account_name: onelake
285-
account_host: onelake.blob.fabric.microsoft.com
286-
client_id: {{ env_var('AZURE_CLIENT_ID') }}
287-
client_secret: {{ env_var('AZURE_CLIENT_SECRET') }}
288-
tenant_id: {{ env_var('AZURE_TENANT_ID') }}
289-
# anon: False # To use azure.identity.DefaultAzureCredential authentication
282+
- fs: abfs
283+
account_name: onelake
284+
account_host: onelake.blob.fabric.microsoft.com
285+
client_id: {{ env_var('AZURE_CLIENT_ID') }}
286+
client_secret: {{ env_var('AZURE_CLIENT_SECRET') }}
287+
tenant_id: {{ env_var('AZURE_TENANT_ID') }}
288+
# anon: False # To use azure.identity.DefaultAzureCredential authentication
290289
```
291290

292291

sqlmesh/core/config/connection.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,9 +377,9 @@ def init(cursor: duckdb.DuckDBPyConnection) -> None:
377377
from fsspec import filesystem # type: ignore
378378

379379
for file_system in self.filesystems:
380-
protocol = file_system.pop("protocol")
381-
storage_options = file_system.pop("storage_options")
382-
fs = filesystem(protocol, **storage_options)
380+
options = file_system.copy()
381+
fs = file_system.pop("fs")
382+
fs = filesystem(fs, **options)
383383
cursor.register_filesystem(fs)
384384

385385
for i, (alias, path_options) in enumerate(

0 commit comments

Comments
 (0)