From c47445cafe58f5562272ccedad11924c1c4cf483 Mon Sep 17 00:00:00 2001 From: Iaroslav Zeigerman Date: Fri, 6 Jun 2025 11:59:33 -0700 Subject: [PATCH 1/2] Chore: Remove obsolete warning when converting a dbt project --- sqlmesh/dbt/model.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sqlmesh/dbt/model.py b/sqlmesh/dbt/model.py index 7f36e93385..51cfd06c88 100644 --- a/sqlmesh/dbt/model.py +++ b/sqlmesh/dbt/model.py @@ -314,14 +314,6 @@ def model_kind(self, context: DbtContext) -> ModelKind: **incremental_by_kind_kwargs, ) - incremental_by_time_str = collection_to_str(INCREMENTAL_BY_TIME_STRATEGIES) - incremental_by_unique_key_str = collection_to_str( - INCREMENTAL_BY_UNIQUE_KEY_STRATEGIES.union(["none"]) - ) - get_console().log_warning( - f"Using unmanaged incremental materialization for model '{self.canonical_name(context)}'. " - f"Some features might not be available. Consider adding either a time_column ({incremental_by_time_str}) or a unique_key ({incremental_by_unique_key_str}) configuration to mitigate this.", - ) strategy = self.incremental_strategy or target.default_incremental_strategy( IncrementalUnmanagedKind ) From fb5a1c1ca7aff1528447becd431ea14d487e9ff2 Mon Sep 17 00:00:00 2001 From: Iaroslav Zeigerman Date: Fri, 6 Jun 2025 12:49:56 -0700 Subject: [PATCH 2/2] fix test --- tests/dbt/test_transformation.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/dbt/test_transformation.py b/tests/dbt/test_transformation.py index c5204aeb55..17b8a6f313 100644 --- a/tests/dbt/test_transformation.py +++ b/tests/dbt/test_transformation.py @@ -1314,7 +1314,6 @@ def test_clickhouse_properties(mocker: MockerFixture): "SQLMesh does not support 'incremental_predicates' - they will not be applied.", "SQLMesh does not support the 'query_settings' model configuration parameter. Specify the query settings directly in the model query.", "SQLMesh does not support the 'sharding_key' model configuration parameter or distributed materializations.", - "Using unmanaged incremental materialization for model '`test`.`model`'. Some features might not be available. Consider adding either a time_column ('delete+insert', 'insert_overwrite') or a unique_key ('merge', 'none') configuration to mitigate this.", ] assert [e.sql("clickhouse") for e in model_to_sqlmesh.partitioned_by] == [