refine

Author: Jicheng Lu

src/Infrastructure/BotSharp.Core.SideCar/Services/BotSharpConversationSideCar.cs

@@ -58,12 +58,16 @@ public async Task<List<DialogElement>> GetConversationDialogs(string conversatio
     {
         if (!IsValid(conversationId))
         {
-            return new List<DialogElement>();
+            return [];
         }
 
-        await Task.CompletedTask;
+        var dialogs = _contextStack.Peek().Dialogs ?? [];
+        if (filter?.Order == "desc")
+        {
+            dialogs = dialogs.OrderByDescending(x => x.MetaData?.CreatedTime).ToList();
+        }
 
-        return _contextStack.Peek().Dialogs;
+        return await Task.FromResult(dialogs);
     }
 
     public async Task UpdateConversationBreakpoint(string conversationId, ConversationBreakpoint breakpoint)
@@ -87,9 +91,7 @@ public async Task UpdateConversationBreakpoint(string conversationId, Conversati
         }
 
         var top = _contextStack.Peek().Breakpoints;
-
-        await Task.CompletedTask;
-        return top.LastOrDefault();
+        return await Task.FromResult(top.LastOrDefault());
     }
 
     public async Task UpdateConversationStates(string conversationId, List<StateKeyValue> states)

src/Infrastructure/BotSharp.Core/Repository/FileRepository/FileRepository.Conversation.cs

@@ -965,9 +965,9 @@ public async Task<bool> SaveConversationFiles(List<ConversationFile> files)
                     Directory.CreateDirectory(convDir);
                 }
 
-                var filesFile = Path.Combine(convDir, CONV_FILES_FILE);
+                var convFile = Path.Combine(convDir, CONV_FILES_FILE);
                 var json = JsonSerializer.Serialize(file, _options);
-                await File.WriteAllTextAsync(filesFile, json);
+                await File.WriteAllTextAsync(convFile, json);
             }
 
             return true;

src/Infrastructure/BotSharp.OpenAPI/Controllers/Conversation/ConversationController.File.cs

@@ -120,6 +120,11 @@ public IActionResult DownloadMessageFile([FromRoute] string conversationId, [Fro
     [HttpPost("/conversation/{conversationId}/thumbnail")]
     public async Task<bool> SaveConversationThumbnail([FromRoute] string conversationId, [FromBody] ConversationFileRequest request)
     {
+        if (request == null)
+        {
+            return false;
+        }
+
         var db = _services.GetRequiredService<IBotSharpRepository>();
         var result = await db.SaveConversationFiles(
         [

src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs

@@ -815,7 +815,7 @@ public async Task<bool> SaveConversationFiles(List<ConversationFile> files)
                                           IsUpsert = true
                                       };
                                   })
-                                  .ToList<WriteModel<ConversationFileDocument>>();
+                                  .ToList();
 
             if (!operations.IsNullOrEmpty())
             {