Avoid conversation title to be updated unexpectly

Author: Oceania2018

src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationService.cs

@@ -11,8 +11,8 @@ public interface IConversationService
     Task SetConversationId(string conversationId, List<MessageState> states, bool isReadOnly = false);
     Task<Conversation> GetConversation(string id, bool isLoadStates = false);
     Task<PagedItems<Conversation>> GetConversations(ConversationFilter filter);
-    Task<Conversation> UpdateConversationTitle(string id, string title);
-    Task<Conversation> UpdateConversationTitleAlias(string id, string titleAlias);
+    Task<bool> UpdateConversationTitle(string id, string title);
+    Task<bool> UpdateConversationTitleAlias(string id, string titleAlias);
     Task<bool> UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags);
     Task<bool> UpdateConversationMessage(string conversationId, UpdateMessageRequest request);
     Task<List<Conversation>> GetLastConversations();

src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationService.SendMessage.cs

@@ -153,7 +153,7 @@ response.RichContent is RichContent<IRichMessage> template &&
         if (response.Instruction != null)
         {
             var conversation = _services.GetRequiredService<IConversationService>();
-            var updatedConversation = await conversation.UpdateConversationTitle(_conversationId, response.Instruction.NextActionReason);
+            await conversation.UpdateConversationTitle(_conversationId, response.Instruction.NextActionReason);
 
             // Emit conversation ending hook
             if (response.Instruction.ConversationEnd)

src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationService.cs

@@ -43,20 +43,26 @@ public async Task<bool> DeleteConversations(IEnumerable<string> ids)
         return isDeleted;
     }
 
-    public async Task<Conversation> UpdateConversationTitle(string id, string title)
+    public async Task<bool> UpdateConversationTitle(string id, string title)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-        await db.UpdateConversationTitle(id, title);
-        var conversation = await db.GetConversation(id);
-        return conversation;
+        if (!string.IsNullOrEmpty(title))
+        {
+            var db = _services.GetRequiredService<IBotSharpRepository>();
+            await db.UpdateConversationTitle(id, title);
+        }
+
+        return true;
     }
 
-    public async Task<Conversation> UpdateConversationTitleAlias(string id, string titleAlias)
+    public async Task<bool> UpdateConversationTitleAlias(string id, string titleAlias)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-        await db.UpdateConversationTitleAlias(id, titleAlias);
-        var conversation = await db.GetConversation(id);
-        return conversation;
+        if (!string.IsNullOrEmpty(titleAlias))
+        {
+            var db = _services.GetRequiredService<IBotSharpRepository>();
+            await db.UpdateConversationTitleAlias(id, titleAlias);
+        }
+
+        return true;
     }
 
     public async Task<bool> UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags)

src/Infrastructure/BotSharp.OpenAPI/Controllers/Conversation/ConversationController.cs

@@ -213,8 +213,8 @@ public async Task<bool> UpdateConversationTitle([FromRoute] string conversationI
             return false;
         }
 
-        var response = await conv.UpdateConversationTitle(conversationId, newTile.NewTitle);
-        return response != null;
+        await conv.UpdateConversationTitle(conversationId, newTile.NewTitle);
+        return true;
     }
 
     [HttpPut("/conversation/{conversationId}/update-title-alias")]