Skip to content

Commit 6eaaa2d

Browse files
committed
dockerfile properly completing runBuild script
1 parent 1847085 commit 6eaaa2d

1 file changed

Lines changed: 16 additions & 4 deletions

File tree

Dockerfile

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ WORKDIR /gpu-flopbench
2222
# Copy the requirements file into the container
2323
COPY ./requirements.txt ./requirements.txt
2424

25+
# if we are on a windows host, we need to remove the CRLF characters from all the files
26+
RUN sed -i 's/\r$//' requirements.txt
27+
2528
# install miniconda
2629
RUN wget https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && \
2730
bash ./Miniconda3-latest-Linux-x86_64.sh -b -p ~/anaconda3 && \
@@ -47,8 +50,17 @@ RUN source ~/anaconda3/bin/activate && \
4750
# Copy the source code into the container
4851
COPY . .
4952

50-
# Config with CMake, and build all the codes
51-
#RUN source ./runBuild.sh
53+
# if we are on a windows host, we need to remove the CRLF characters from all the files
54+
#RUN find . -type f -exec sed -i 's/\r$//' {} +
55+
RUN find . -type f \
56+
-not -name "*.gz" \
57+
-not -name "*.zip" \
58+
-not -name "*.rar" \
59+
-not -name "*.7z" \
60+
-not -name "*.tar" \
61+
-not -name "*.bz2" \
62+
-not -name "*.tar.*" \
63+
-exec sed -i 's/\r$//' {} +
5264

53-
# Verify that executables were built
54-
#RUN test -n "$(find build -maxdepth 1 -type f -executable)" || (echo "No executables found in ./build" && exit 1)
65+
# one of the issues with a windows host is that the execute permissions are not preserved when copying files into the container
66+
# this is okay, and it seems like everything works fine without needing to change it.

0 commit comments

Comments
 (0)