Merge pull request #199 from SenseUnit/fix_excess_auth_messages

Snawoot · web-flow · commit 871d35df1233 · 2026-03-09T23:31:16.000+02:00
Fix excess logging on password auth failure
diff --git a/auth/common.go b/auth/common.go
@@ -39,6 +39,9 @@ func requireBasicAuth(ctx context.Context, wr http.ResponseWriter, req *http.Req
 }
 
 func tryValid(auth Auth, logger *clog.CondLogger, user, password, userAddr string) bool {
+	if auth == nil {
+		return false
+	}
 	if validator, ok := auth.(interface {
 		Valid(string, string, string) bool
 	}); ok {

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,9 @@ func requireBasicAuth(ctx context.Context, wr http.ResponseWriter, req *http.Req`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`func tryValid(auth Auth, logger *clog.CondLogger, user, password, userAddr string) bool {`
	`42`	`+ if auth == nil {`
	`43`	`+ return false`
	`44`	`+ }`
`42`	`45`	`if validator, ok := auth.(interface {`
`43`	`46`	`Valid(string, string, string) bool`
`44`	`47`	`}); ok {`