Remove double execution of Drop SQL Scripts

Author: mythz

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -84,11 +84,6 @@ internal static bool CreateTable(this IDbCommand dbCmd, bool overwrite, Type mod
             var tableExists = dialectProvider.DoesTableExist(dbCmd, tableName, schema);
             if (overwrite && tableExists)
             {
-                if (modelDef.PreDropTableSql != null)
-                {
-                    ExecuteSql(dbCmd, modelDef.PreDropTableSql);
-                }
-
                 DropTable(dbCmd, modelDef);
 
                 var postDropTableSql = dialectProvider.ToPostDropTableStatement(modelDef);
@@ -97,11 +92,6 @@ internal static bool CreateTable(this IDbCommand dbCmd, bool overwrite, Type mod
                     ExecuteSql(dbCmd, postDropTableSql);
                 }
 
-                if (modelDef.PostDropTableSql != null)
-                {
-                    ExecuteSql(dbCmd, modelDef.PostDropTableSql);
-                }
-
                 tableExists = false;
             }
 

tests/ServiceStack.OrmLite.Tests/CustomSqlTests.cs

@@ -80,6 +80,18 @@ public class ModelWithPostDropSql
         public string Name { get; set; }
     }
 
+    [PreDropTable("-- PreDropTable")]
+    [PostDropTable("-- PostDropTable")]
+    [PreCreateTable("-- PreCreateTable")]
+    [PostCreateTable("-- PostCreateTable")]
+    public class ModelWithPreAndPostDrop
+    {
+        [AutoIncrement]
+        public int Id { get; set; }
+
+        public string Name { get; set; }
+    }
+
     [TestFixtureOrmLite]
     public class CustomSqlTests : OrmLiteProvidersTestBase
     {
@@ -165,6 +177,14 @@ public void Does_execute_CustomSql_after_table_created_using_dynamic_attribute()
             Assert.That(seedDataNames, Is.EquivalentTo(new[] {"Foo", "Bar"}));
         }
 
+        [Test]
+        public void Does_execute_PostCreateTable_and_PreDropTable()
+        {
+            OrmLiteUtils.PrintSql();
+            using var db = OpenDbConnection();
+            db.CreateTable<ModelWithPreAndPostDrop>(true);
+        }
+
         [Test]
         public void Does_execute_CustomSql_before_table_dropped()
         {