Handle if value from SQLite Reader is already a bool

Author: mythz

src/ServiceStack.OrmLite.Sqlite/Converters/SqliteBoolConverter.cs

@@ -22,6 +22,9 @@ public override object ToDbValue(Type fieldType, object value)
 
         public override object FromDbValue(Type fieldType, object value)
         {
+            if (value is bool b)
+                return b;
+            
             var intVal = int.Parse(value.ToString());
             return intVal != 0;
         }

tests/ServiceStack.OrmLite.SqliteTests/Issues/BooleanTests.cs

@@ -0,0 +1,71 @@
+using System.Threading.Tasks;
+using NUnit.Framework;
+using ServiceStack.DataAnnotations;
+using ServiceStack.Text;
+
+namespace ServiceStack.OrmLite.Tests.Issues
+{
+    [Alias("users")]
+    public class User
+    {
+        [Alias("id"), PrimaryKey, Required, AutoIncrement]
+        public int Id { get; set; }
+
+        [Alias("username")]
+        public string Username { get; set; }
+
+        [Alias("password")]
+        public string Password { get; set; }
+
+        [Alias("system_admin"), Required]
+        public bool IsSystemAdmin { get; set; }
+
+        [Alias("system_user"), Required]
+        public bool IsSystemUser { get; set; }
+
+        [Alias("is_admin"), Required]
+        public bool IsAdmin { get; set; }
+
+        [Alias("notes")]
+        public string Notes { get; set; }
+    }
+    
+    public class BooleanTests
+    {
+        [Test]
+        public async Task Can_create_user_with_BOOLEAN_columns()
+        {
+            var factory = new OrmLiteConnectionFactory(":memory:", SqliteDialect.Provider);
+            using var db = await factory.OpenAsync();
+            OrmLiteUtils.PrintSql();
+
+            db.ExecuteSql(@"
+CREATE TABLE IF NOT EXISTS `users` (
+`id`	INTEGER NOT NULL,
+`username`	VARCHAR,
+`system_user`	BOOLEAN,
+`system_admin`	BOOLEAN,
+`is_admin`	BOOLEAN,
+`password`	VARCHAR,
+`notes`	VARCHAR,
+PRIMARY KEY(`id`)
+);");
+
+            var row = new User {
+                Notes = "notes", 
+                IsAdmin = true, 
+                Username = "user", 
+                Password = "pass"
+            };
+
+            await db.SaveAsync(row);
+
+            var dbRow = await db.SingleByIdAsync<User>(row.Id);
+            Assert.That(dbRow.Id, Is.EqualTo(row.Id));
+            Assert.That(dbRow.Notes, Is.EqualTo(row.Notes));
+            Assert.That(dbRow.IsAdmin, Is.EqualTo(row.IsAdmin));
+            Assert.That(dbRow.Username, Is.EqualTo(row.Username));
+            Assert.That(dbRow.Password, Is.EqualTo(row.Password));
+        }
+    }
+}

tests/ServiceStack.OrmLite.Tests.Setup/TestConfig.cs

@@ -2,11 +2,7 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Data;
-using System.Data.Common;
-using System.Data.SqlClient;
-using System.IO;
 using System.Linq;
-using ServiceStack.Text;
 
 namespace ServiceStack.OrmLite.Tests
 {