Rename DisableVerboseLogging to EnableVerboseLogging and disable by default

Author: mythz

src/ServiceStack.Redis/RedisConfig.cs

@@ -83,15 +83,22 @@ public class RedisConfig
         public static int? AssumeServerVersion;
 
         /// <summary>
-        /// How long to hold deactivated clients for before disposing their connection (default 10 seconds)
+        /// How long to hold deactivated clients for before disposing their connection (default 0 seconds)
         /// Dispose of deactivated Clients immediately with TimeSpan.Zero
         /// </summary>
-        public static TimeSpan DeactivatedClientsExpiry = TimeSpan.FromSeconds(10);
+        public static TimeSpan DeactivatedClientsExpiry = TimeSpan.Zero;
 
         /// <summary>
-        /// Whether Debug Logging should log detailed Redis operations (default false)
+        /// Whether Debug Logging should log detailed Redis operations (default true)
         /// </summary>
-        public static bool DisableVerboseLogging = false;
+        public static bool EnableVerboseLogging = false;
+
+        [Obsolete("Use EnableVerboseLogging")]
+        public static bool DisableVerboseLogging
+        {
+            get => !EnableVerboseLogging;
+            set => EnableVerboseLogging = !value;
+        }
 
         //Example at: http://msdn.microsoft.com/en-us/library/office/dd633677(v=exchg.80).aspx 
         public static LocalCertificateSelectionCallback CertificateSelectionCallback { get; set; }
@@ -121,8 +128,8 @@ public static void Reset()
             VerifyMasterConnections = true;
             HostLookupTimeoutMs = 200;
             AssumeServerVersion = null;
-            DeactivatedClientsExpiry = TimeSpan.FromSeconds(10);
-            DisableVerboseLogging = false;
+            DeactivatedClientsExpiry = TimeSpan.Zero;
+            EnableVerboseLogging = false;
             CertificateSelectionCallback = null;
             CertificateValidationCallback = null;
             AssertAccessOnlyOnSameThread = false;

src/ServiceStack.Redis/RedisManagerPool.cs

@@ -182,7 +182,7 @@ public IRedisClient GetClient()
                         if (inactivePoolIndex == -1 || !stillReserved)
                         {
                             if (Log.IsDebugEnabled)
-                                Log.Debug("clients[inactivePoolIndex] != existingClient: {0}".Fmt(!stillReserved ? "!stillReserved" : "-1"));
+                                Log.Debug($"POOL clients[inactivePoolIndex] != existingClient: {(!stillReserved ? "!stillReserved" : "-1")}");
 
                             Interlocked.Increment(ref RedisState.TotalClientsCreatedOutsidePool);
 

src/ServiceStack.Redis/RedisNativeClient_Utils.cs

@@ -302,7 +302,7 @@ private RedisResponseException CreateResponseError(string error)
         {
             DeactivatedAt = DateTime.UtcNow;
 
-            if (!RedisConfig.DisableVerboseLogging)
+            if (RedisConfig.EnableVerboseLogging)
             {
                 var safeLastCommand = string.IsNullOrEmpty(Password)
                     ? lastCommand
@@ -374,7 +374,7 @@ protected void WriteCommandToSendBuffer(params byte[][] cmdWithBinaryArgs)
                     LicenseUtils.AssertValidUsage(LicenseFeature.Redis, QuotaType.RequestsPerHour, __requestsPerHour);
             }
 
-            if (log.IsDebugEnabled && !RedisConfig.DisableVerboseLogging)
+            if (log.IsDebugEnabled && RedisConfig.EnableVerboseLogging)
                 CmdLog(cmdWithBinaryArgs);
 
             //Total command lines count
@@ -476,7 +476,7 @@ internal void FlushSendBuffer()
                 }
                 else
                 {
-                    //Sendling IList<ArraySegment> Throws 'Message to Large' SocketException in Mono
+                    //Sending IList<ArraySegment> Throws 'Message to Large' SocketException in Mono
                     foreach (var segment in cmdBuffer)
                     {
                         var buffer = segment.Array;
@@ -739,7 +739,7 @@ protected string SendExpectString(params byte[][] cmdWithBinaryArgs)
 
         protected void Log(string fmt, params object[] args)
         {
-            if (RedisConfig.DisableVerboseLogging)
+            if (RedisConfig.EnableVerboseLogging)
                 return;
 
             log.DebugFormat("{0}", string.Format(fmt, args).Trim());

tests/Console.Tests/BlockingPop.cs

@@ -25,7 +25,7 @@ public void Execute()
             RedisConfig.VerifyMasterConnections = true;
             RedisConfig.HostLookupTimeoutMs = 1000;
             RedisConfig.DeactivatedClientsExpiry = TimeSpan.FromSeconds(15);
-            RedisConfig.DisableVerboseLogging = false;
+            RedisConfig.EnableVerboseLogging = true;
 
             var redisManager = new RedisManagerPool("localhost?connectTimeout=1000");
 

tests/Console.Tests/ForceFailover.cs

@@ -9,7 +9,7 @@ public class ForceFailover
     {
         public void Execute()
         {
-            RedisConfig.DisableVerboseLogging = true;
+            RedisConfig.EnableVerboseLogging = false;
             LogManager.LogFactory = new ConsoleLogFactory(debugEnabled:true);
 
             var sentinel = new RedisSentinel(new [] {

tests/Console.Tests/RedisSentinelFailoverTests.cs

@@ -23,7 +23,7 @@ public abstract class RedisSentinelFailoverTests
 
         public void Execute()
         {
-            RedisConfig.DisableVerboseLogging = true;
+            RedisConfig.EnableVerboseLogging = false;
             LogManager.LogFactory = new ConsoleLogFactory(debugEnabled: true);
             log = LogManager.GetLogger(GetType());