Add generic typed string escaping tests

Author: mythz

src/ServiceStack.Redis/Generic/RedisTypedClient.cs

@@ -36,15 +36,9 @@ static RedisTypedClient()
         readonly ITypeSerializer<T> serializer = new JsonSerializer<T>();
         private readonly RedisClient client;
 
-        public IRedisClient RedisClient
-        {
-            get { return client; }
-        }
+        public IRedisClient RedisClient => client;
 
-        public IRedisNativeClient NativeClient
-        {
-            get { return client; }
-        }
+        public IRedisNativeClient NativeClient => client;
 
         /// <summary>
         /// Use this to share the same redis connection with another
@@ -88,26 +82,14 @@ public IDisposable AcquireLock(TimeSpan timeOut)
 
         public IRedisTransactionBase Transaction
         {
-            get
-            {
-                return client.Transaction;
-            }
-            set
-            {
-                client.Transaction = value;
-            }
+            get => client.Transaction;
+            set => client.Transaction = value;
         }
 
         public IRedisPipelineShared Pipeline
         {
-            get
-            {
-                return client.Pipeline;
-            }
-            set
-            {
-                client.Pipeline = value;
-            }
+            get => client.Pipeline;
+            set => client.Pipeline = value;
         }
 
         public void Watch(params string[] keys)
@@ -155,18 +137,12 @@ public string UrnKey(T entity)
             return client.UrnKey(entity);
         }
 
-        public IRedisSet TypeIdsSet
-        {
-            get
-            {
-                return new RedisClientSet(client, client.GetTypeIdsSetKey<T>());
-            }
-        }
+        public IRedisSet TypeIdsSet => new RedisClientSet(client, client.GetTypeIdsSetKey<T>());
 
         public T this[string key]
         {
-            get { return GetValue(key); }
-            set { SetValue(key, value); }
+            get => GetValue(key);
+            set => SetValue(key, value);
         }
 
         public byte[] SerializeValue(T value)
@@ -184,7 +160,7 @@ public T DeserializeValue(byte[] value)
         public void SetValue(string key, T entity)
         {
             if (key == null)
-                throw new ArgumentNullException("key");
+                throw new ArgumentNullException(nameof(key));
 
             client.Set(key, SerializeValue(entity));
             client.RegisterTypeId(entity);
@@ -193,7 +169,7 @@ public void SetValue(string key, T entity)
         public void SetValue(string key, T entity, TimeSpan expireIn)
         {
             if (key == null)
-                throw new ArgumentNullException("key");
+                throw new ArgumentNullException(nameof(key));
 
             client.Set(key, SerializeValue(entity), expireIn);
             client.RegisterTypeId(entity);

tests/ServiceStack.Redis.Tests/Generic/RedisTypedClientAppTests.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using NUnit.Framework;
-using ServiceStack.Common;
 using ServiceStack.Redis.Generic;
 
 namespace ServiceStack.Redis.Tests.Generic
@@ -229,5 +228,34 @@ public void Can_GetEarliestFromRecentsList()
             Assert.That(expectedAnswers.EquivalentTo(earliest3Answers));
         }
 
+        [Test]
+        public void Can_save_quoted_strings()
+        {
+            var str = "string \"with\" \"quotes\"";
+            var cacheKey = "quotetest";
+
+            Redis.As<string>().SetValue(cacheKey, str);
+            var fromRedis = Redis.As<string>().GetValue(cacheKey);
+            Assert.That(fromRedis, Is.EqualTo(str));
+
+            Redis.Set(cacheKey, str);
+            fromRedis = Redis.Get<string>(cacheKey);
+            Assert.That(fromRedis, Is.EqualTo(str));
+
+            Redis.SetValue(cacheKey, str);
+            fromRedis = Redis.GetValue(cacheKey);
+            Assert.That(fromRedis, Is.EqualTo(str));
+
+            Redis.SetValue(cacheKey, str.ToJson());
+            fromRedis = Redis.GetValue(cacheKey).FromJson<string>();
+            Assert.That(fromRedis, Is.EqualTo(str));
+        }
+
+        [Test]
+        public void Does_return_non_existent_keys_as_defaultValue()
+        {
+            Assert.That(Redis.Get<string>("notexists"), Is.Null);
+            Assert.That(Redis.Get<int>("notexists"), Is.EqualTo(0));
+        }
     }
 }