Use explicit flag to determine if command was written to buffer

Author: mythz

src/ServiceStack.Redis/RedisNativeClient_Utils.cs

@@ -526,6 +526,7 @@ protected T SendReceive<T>(byte[][] cmdWithBinaryArgs,
             }
 
             var i = 0;
+            var didWriteToBuffer = false;
             Exception originalEx = null;
 
             var firstAttempt = DateTime.UtcNow;
@@ -539,8 +540,11 @@ protected T SendReceive<T>(byte[][] cmdWithBinaryArgs,
                     if (socket == null)
                         throw new RedisRetryableException("Socket is not connected");
 
-                    if (i == 0) //only write to buffer once
+                    if (!didWriteToBuffer) //only write to buffer once
+                    {
                         WriteCommandToSendBuffer(cmdWithBinaryArgs);
+                        didWriteToBuffer = true;
+                    }
 
                     if (Pipeline == null) //pipeline will handle flush if in pipeline
                     {

tests/Console.Tests/BlockingRemoveAfterReconnection.cs

@@ -0,0 +1,35 @@
+using System;
+using System.Threading;
+using System.Threading.Tasks;
+using ServiceStack.Logging;
+using ServiceStack.Redis;
+using ServiceStack.Text;
+
+namespace ConsoleTests
+{
+    public class BlockingRemoveAfterReconnection
+    {
+        protected internal static RedisManagerPool BasicRedisClientManager;
+
+        public void Execute()
+        {
+            //RedisConfig.AssumeServerVersion = 4000;
+            RedisConfig.DefaultConnectTimeout = 20 * 1000;
+            RedisConfig.DefaultRetryTimeout = 20 * 1000;
+            BasicRedisClientManager = new RedisManagerPool();
+            try
+            {
+                using (var client = BasicRedisClientManager.GetClient())
+                {
+                    Console.WriteLine("Blocking...");
+                    var fromList = client.BlockingRemoveStartFromList("AnyQueue", TimeSpan.FromMinutes(20));
+                    Console.WriteLine($"Received: {fromList.Dump()}");
+                }
+            }
+            catch (Exception e)
+            {
+                Console.WriteLine(e);
+            }
+        }
+    }
+}

tests/Console.Tests/Console.Tests.csproj

@@ -81,6 +81,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="BlockingPop.cs" />
+    <Compile Include="BlockingRemoveAfterReconnection.cs" />
     <Compile Include="BrPopAfterReconnection.cs" />
     <Compile Include="ForceFailover.cs" />
     <Compile Include="MasterFailoverWithPassword.cs" />

tests/Console.Tests/Program.cs

@@ -38,7 +38,7 @@ static void Main(string[] args)
 
             //new MasterFailoverWithPassword().Execute();
 
-            new BrPopAfterReconnection().Execute();
+            new BlockingRemoveAfterReconnection().Execute();
         }
     }
 }