we have got a much better bug reporting methode now.

Author: thsc42

src/net/sharksystem/asap/util/Batchprocessor.java

@@ -10,11 +10,12 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public class Batchprocessor extends Thread {
+public class Batchprocessor implements Runnable {
     List<String> cmdList = new ArrayList<>();
     private CmdLineUI cmdLineUI;
     private PrintStream printStream;
     private ByteArrayInputStream inputStream;
+    private Thread runningThread;
 
     public Batchprocessor() {
         this(true);
@@ -31,8 +32,24 @@ public void addCommand(String cmd) {
         this.cmdList.add(cmd);
     }
 
-    @Override
-    public void run() {
+    public void execute() {
+        this.prepareExecution();
+        this.doExecution();
+    }
+
+    public void executeAsThread() {
+        this.prepareExecution();
+        this.runningThread = new Thread(this);
+        this.runningThread.start();
+    }
+
+    public void join() throws InterruptedException {
+        if(this.runningThread != null && this.runningThread.isAlive()) {
+            this.runningThread.join();
+        }
+    }
+
+    private void prepareExecution() {
         // prepare output
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
         PrintStream ps = new PrintStream(baos);
@@ -41,11 +58,16 @@ public void run() {
             ps.println(cmd);
         }
 
+        // clean cmd list
+        this.cmdList = new ArrayList<>();
+
         ByteArrayInputStream bais = new ByteArrayInputStream(baos.toByteArray());
 
         this.printStream = System.out;
         this.inputStream = bais;
+    }
 
+    private void doExecution() {
         this.cmdLineUI.runCommandLoop(this.printStream, this.inputStream);
 
         // in any case - give it some time to tidy up
@@ -54,5 +76,12 @@ public void run() {
         } catch (InterruptedException e) {
             // ignore
         }
+
+        this.runningThread = null;
+    }
+
+    @Override
+    public void run() {
+        this.doExecution();
     }
 }

src/net/sharksystem/cmdline/CmdLineUI.java

@@ -301,8 +301,7 @@ public void runCommandLoop() {
                         this.doKill("all");
                         again = false; break; // end loop
 
-                    default: this.consoleOutput.println("unknown command:" +
-                            cmdLineString);
+                    default: System.err.println("unknown command:" + cmdLineString);
                         this.printUsage();
                         rememberCommand = false;
                         break;

test/net/sharksystem/asap/BatchprocessorTest.java

@@ -10,35 +10,65 @@ public class BatchprocessorTest {
     public void secondMessageNotSendTest() throws IOException, ASAPException, InterruptedException {
         Batchprocessor aliceCommands = new Batchprocessor();
         Batchprocessor bobCommands = new Batchprocessor();
+
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+        System.out.println("+                           STEP 1                        +");
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+
+        // prepare
         aliceCommands.addCommand(
                 "newpeer Alice\n" +
                         "newapp Alice chat\n" +
                         "newmessage Alice chat sn2://abChat HiBob\n" +
-                        "connect 7070 Alice\n" +
-                        "sleep 2000\n" +
-                        "newmessage Alice chat sn2://abChat HiBob2\n" +
-                        "sleep 1000\n" +
-                        "kill all\n" +
-                        "open 7071 Alice\n" +
-                        "sleep 5000"
-                        );
-
+                        "open 7070 Alice");
 
         bobCommands.addCommand(
                 "newpeer Bob\n" +
                         "newapp Bob chat\n" +
                         "newmessage Bob chat sn2://abChat HiAlice\n" +
-                        "open 7070 Bob\n" +
-                        "sleep 1000\n" +
-                        "connect 7071 Bob\n" +
-                        "sleep 1000"
-        );
+                        "connect 7070 Bob");
 
-        // lets go
-        aliceCommands.start();
-        bobCommands.start();
+        aliceCommands.executeAsThread();
+        bobCommands.executeAsThread();
 
+        // give it some time
+        Thread.sleep(1000);
+        // wait until ends
         aliceCommands.join();
         bobCommands.join();
+
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+        System.out.println("+                           STEP 2                        +");
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+
+        // add message while online - terminate connection
+        aliceCommands.addCommand(
+                        "newmessage Alice chat sn2://abChat HiBob2\n" +
+                        "kill all");
+
+        aliceCommands.execute();
+
+        // connection closed - re-establish - Bob as TCP server now
+        aliceCommands.addCommand(
+        "sleep 500\n" +
+            "connect 7071 Alice");
+
+        bobCommands.addCommand("open 7071 Bob");
+
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+        System.out.println("+                           STEP 3                        +");
+        System.out.println("+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++");
+
+        aliceCommands.executeAsThread();
+        bobCommands.executeAsThread();
+
+        // give it some time
+        Thread.sleep(1000);
+        // wait until ends
+        aliceCommands.join();
+        bobCommands.join();
+
+        // problem Alice' second message is not transmitted
+
     }
 }