parser: Fix NULL checks for output arguments

nwellnhof · nwellnhof · commit 8318b5a63465 · 2024-06-09T15:08:43.000+02:00
diff --git a/entities.c b/entities.c
@@ -290,7 +290,8 @@ xmlAddEntity(xmlDocPtr doc, int extSubset, const xmlChar *name, int type,
 	dtd->last = (xmlNodePtr) ret;
     }
 
-    *out = ret;
+    if (out != NULL)
+        *out = ret;
     return(0);
 }
 
diff --git a/parser.c b/parser.c
@@ -12172,7 +12172,7 @@ xmlParseCtxtExternalEntity(xmlParserCtxtPtr ctxt, const xmlChar *URL,
     xmlCtxtInitializeLate(ctxt);
 
     list = xmlCtxtParseContent(ctxt, input, /* hasTextDecl */ 1, 1);
-    if (*listOut != NULL)
+    if (listOut != NULL)
         *listOut = list;
     else
         xmlFreeNodeList(list);

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,8 @@ xmlAddEntity(xmlDocPtr doc, int extSubset, const xmlChar *name, int type,`
`290`	`290`	`dtd->last = (xmlNodePtr) ret;`
`291`	`291`	`}`
`292`	`292`
`293`		`- *out = ret;`
	`293`	`+ if (out != NULL)`
	`294`	`+ *out = ret;`
`294`	`295`	`return(0);`
`295`	`296`	`}`
`296`	`297`