parser: Fix detection of duplicate attributes in XML namespace

nwellnhof · nwellnhof · commit ece73bd8fd0f · 2024-03-12T22:35:10.000+01:00
Fixes a regression from commit e0dd330, resulting in duplicate attributes in the predefined XML namespace not being detected or extraneous default attributes being passed. Fixes #704.
diff --git a/parser.c b/parser.c
@@ -9424,7 +9424,7 @@ xmlAttrHashInsert(xmlParserCtxtPtr ctxt, unsigned size, const xmlChar *name,
             int nsIndex = (int) (ptrdiff_t) atts[2];
 
             if ((nsIndex == NS_INDEX_EMPTY) ? (uri == NULL) :
-                (nsIndex == NS_INDEX_XML) ? (uri == ctxt->str_xml) :
+                (nsIndex == NS_INDEX_XML) ? (uri == ctxt->str_xml_ns) :
                 (uri == ctxt->nsTab[nsIndex * 2 + 1]))
                 return(bucket->index);
         }

Original file line number	Diff line number	Diff line change
`@@ -9424,7 +9424,7 @@ xmlAttrHashInsert(xmlParserCtxtPtr ctxt, unsigned size, const xmlChar *name,`
`9424`	`9424`	`int nsIndex = (int) (ptrdiff_t) atts[2];`
`9425`	`9425`
`9426`	`9426`	`if ((nsIndex == NS_INDEX_EMPTY) ? (uri == NULL) :`
`9427`		`- (nsIndex == NS_INDEX_XML) ? (uri == ctxt->str_xml) :`
	`9427`	`+ (nsIndex == NS_INDEX_XML) ? (uri == ctxt->str_xml_ns) :`
`9428`	`9428`	`(uri == ctxt->nsTab[nsIndex * 2 + 1]))`
`9429`	`9429`	`return(bucket->index);`
`9430`	`9430`	`}`