Skip to content

Commit 1f05342

Browse files
committed
[add] missing XML comments
[r] method name [del] unused variable
1 parent 6e2cc6e commit 1f05342

39 files changed

Lines changed: 438 additions & 46 deletions

src/Simplify.Web.Tests/StaticFiles/Handlers/CachedFileHandlerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void CanHandle_CantBeCached_False()
4646
}
4747

4848
[Test]
49-
public async Task Execute_CachedFile_RespectiveResponsePropertiesAreSet()
49+
public async Task ExecuteAsync_CachedFile_RespectiveResponsePropertiesAreSet()
5050
{
5151
// Arrange
5252

@@ -60,7 +60,7 @@ public async Task Execute_CachedFile_RespectiveResponsePropertiesAreSet()
6060
var response = Mock.Of<HttpResponse>(x => x.Headers == new HeaderDictionary());
6161

6262
// Act
63-
await _handler.Execute(context, response);
63+
await _handler.ExecuteAsync(context, response);
6464

6565
// Assert
6666

src/Simplify.Web.Tests/StaticFiles/Handlers/NewFileHandlerTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public void CanHandle_CantBeCached_True()
4747
// Arrange
4848

4949
var context = Mock.Of<IStaticFileProcessingContext>(x => x.CanBeCached == false);
50-
var handler = new NewFileHandler(null!, null!);
5150

5251
// Act
5352
var result = _handler.CanHandle(context);
@@ -57,7 +56,7 @@ public void CanHandle_CantBeCached_True()
5756
}
5857

5958
[Test]
60-
public async Task Execute_NewFile_FileSendToClientAndRespectiveResponsePropertiesAreSet()
59+
public async Task ExecuteAsync_NewFile_FileSendToClientAndRespectiveResponsePropertiesAreSet()
6160
{
6261
// Arrange
6362

@@ -76,7 +75,7 @@ public async Task Execute_NewFile_FileSendToClientAndRespectiveResponsePropertie
7675
var response = Mock.Of<HttpResponse>(x => x.Headers == new HeaderDictionary());
7776

7877
// Act
79-
await _handler.Execute(context, response);
78+
await _handler.ExecuteAsync(context, response);
8079

8180
// Assert
8281

src/Simplify.Web.Tests/StaticFiles/StaticFileRequestHandlingPipelineTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public async Task ExecuteAsync_ThreeStepsSecondCanHandle_SecondCalled()
2828

2929
// Asset
3030

31-
handler1.Verify(x => x.Execute(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()), Times.Never);
32-
handler2.Verify(x => x.Execute(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()));
33-
handler3.Verify(x => x.Execute(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()), Times.Never);
31+
handler1.Verify(x => x.ExecuteAsync(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()), Times.Never);
32+
handler2.Verify(x => x.ExecuteAsync(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()));
33+
handler3.Verify(x => x.ExecuteAsync(It.IsAny<IStaticFileProcessingContext>(), It.IsAny<HttpResponse>()), Times.Never);
3434
}
3535
}

src/Simplify.Web/ControllerResponse.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public abstract class ControllerResponse : ActionModulesAccessor
1818
public virtual IResponseWriter ResponseWriter { get; internal set; } = null!;
1919

2020
/// <summary>
21-
/// Executes this response
21+
/// Executes this response asynchronously.
2222
/// </summary>
2323
public abstract Task<ResponseBehavior> ExecuteAsync();
2424
}

src/Simplify.Web/PropertiesInjection/ActionModulesAccessorInjector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace Simplify.Web.PropertiesInjection;
88

99
/// <summary>
10-
/// Provides the builder for ActionModulesAccessor objects.
10+
/// Provides the action modules accessor injector.
1111
/// </summary>
1212
public abstract class ActionModulesAccessorInjector(IDIResolver resolver) : ModulesAccessorInjector(resolver)
1313
{

src/Simplify.Web/PropertiesInjection/ModulesAccessorInjector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
namespace Simplify.Web.PropertiesInjection;
77

88
/// <summary>
9-
/// Provides the builder for ModulesAccessor objects.
9+
/// Provides the modules accessor injector.
1010
/// </summary>
1111
public abstract class ModulesAccessorInjector(IDIResolver resolver) : ViewAccessorInjector(resolver)
1212
{

src/Simplify.Web/PropertiesInjection/ViewAccessorInjector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
namespace Simplify.Web.PropertiesInjection;
55

66
/// <summary>
7-
/// Provides the builder for ViewAccessor objects construction.
7+
/// Provides the view accessor injector.
88
/// </summary>
99
public abstract class ViewAccessorInjector(IDIResolver resolver)
1010
{

src/Simplify.Web/RequestHandling/Handlers/ControllersHandler.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,17 @@
55

66
namespace Simplify.Web.RequestHandling.Handlers;
77

8+
/// <summary>
9+
/// Provides the controllers handler.
10+
/// </summary>
11+
/// <seealso cref="IRequestHandler" />
812
public class ControllersHandler(IExecutionWorkOrderBuildDirector workOrderBuildDirector, IControllersExecutor controllersExecutor) : IRequestHandler
913
{
14+
/// <summary>
15+
/// Handle the request.
16+
/// </summary>
17+
/// <param name="context">The context.</param>
18+
/// <param name="next">The next handler in the chain.</param>
1019
public async Task HandleAsync(HttpContext context, RequestHandlerAsync next)
1120
{
1221
var workOrder = workOrderBuildDirector.CreateWorkOrder(context);

src/Simplify.Web/RequestHandling/Handlers/PageGenerationHandler.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,17 @@
55

66
namespace Simplify.Web.RequestHandling.Handlers;
77

8+
/// <summary>
9+
/// Provides the page generation handler.
10+
/// </summary>
11+
/// <seealso cref="IRequestHandler" />
812
public class PageGenerationHandler(IPageComposer pageComposer, IResponseWriter responseWriter) : IRequestHandler
913
{
14+
/// <summary>
15+
/// Handle the request.
16+
/// </summary>
17+
/// <param name="context">The context.</param>
18+
/// <param name="next">The next handler in the chain.</param>
1019
public Task HandleAsync(HttpContext context, RequestHandlerAsync next)
1120
{
1221
context.Response.ContentType = "text/html";

src/Simplify.Web/RequestHandling/Handlers/SetLoginUrlForUnauthorizedRequestHandler.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,17 @@
55

66
namespace Simplify.Web.RequestHandling.Handlers;
77

8+
/// <summary>
9+
/// Provides the set login URL for unauthorized request handler.
10+
/// </summary>
11+
/// <seealso cref="IRequestHandler" />
812
public class SetLoginUrlForUnauthorizedRequestHandler(IRedirector redirector) : IRequestHandler
913
{
14+
/// <summary>
15+
/// Handle the request.
16+
/// </summary>
17+
/// <param name="context">The context.</param>
18+
/// <param name="next">The next handler in the chain.</param>
1019
public async Task HandleAsync(HttpContext context, RequestHandlerAsync next)
1120
{
1221
await next();

0 commit comments

Comments
 (0)