tslint new rules (#94)

Author: Martynas Žilinskas

.travis.yml

@@ -6,7 +6,7 @@ notifications:
 node_js:
 - stable
 before_install:
-- "npm install -g npm@^4.6.1"
+- "npm install -g npm@^5.0.3"
 - "npm install -g typescript@^2.3"
 script:
 - npm run generate

package.json

@@ -5,7 +5,7 @@
     "generate": "rush generate",
     "tools-build": "npm run rush-tools -- run gulp-build -e simplr-mvdir",
     "source-build": "npm run rush-tools -- run build -e simplr-mvdir",
-    "test": "npm run rush-tools -- run test-tsc -e simplr-mvdir",
+    "test": "npm run rush-tools -- run test -e simplr-mvdir",
     "rush-tools": "ts-node ./tools/rush-tools.ts",
     "publish": "npm run rush-tools -- publish"
   },

packages/simplr-forms-dom/__tests__/components/clear.test.tsx

@@ -15,7 +15,7 @@ describe("Clear button", () => {
         sandbox = Sinon.sandbox.create();
     });
 
-    afterEach(function () {
+    afterEach(() => {
         sandbox.restore();
     });
 
@@ -34,11 +34,11 @@ describe("Clear button", () => {
 
     it("clears fields by fieldsIds", () => {
         const callback = sandbox.stub(FormStore.prototype, "ClearFields");
-        let fieldsIds: string[] = [];
+        const fieldsIds: string[] = [];
         for (let i = 0; i < 5; i++) {
             fieldsIds.push(`text-${i}`);
         }
-        let fields: JSX.Element[] = [];
+        const fields: JSX.Element[] = [];
         fieldsIds.forEach(value => {
             fields.push(<Text name={value} key={value} />);
         });

packages/simplr-forms-dom/__tests__/components/reset.test.tsx

@@ -15,7 +15,7 @@ describe("Reset button", () => {
         sandbox = Sinon.sandbox.create();
     });
 
-    afterEach(function () {
+    afterEach(() => {
         sandbox.restore();
     });
 
@@ -34,11 +34,11 @@ describe("Reset button", () => {
 
     it("reset fields by fieldsIds", () => {
         const callback = sandbox.spy(FormStore.prototype, "ResetFields");
-        let fieldsIds: string[] = [];
+        const fieldsIds: string[] = [];
         for (let i = 0; i < 5; i++) {
             fieldsIds.push(`text-${i}`);
         }
-        let fields: JSX.Element[] = [];
+        const fields: JSX.Element[] = [];
         fieldsIds.forEach(value => {
             fields.push(<Text name={value} key={value} />);
         });

packages/simplr-forms-dom/__tests__/tsconfig.json

@@ -12,10 +12,14 @@
         "strict": true,
         "noEmit": true,
         "noUnusedLocals": true,
+        "importHelpers": true,
         "lib": [
             "dom",
             "dom.iterable",
             "es6"
+        ],
+        "typeRoots": [
+            "../node_modules/@types/"
         ]
     },
     "exclude": [

packages/simplr-forms-dom/package.json

@@ -12,8 +12,8 @@
     "watch": "webpack -w",
     "uglifyjs": "uglifyjs ./dist/simplr-forms-dom.js -o ./dist/simplr-forms-dom.min.js --compress --mangle",
     "release": "npm run build && npm run uglifyjs",
-    "test": "jest",
-    "test-tslint": "tslint --config ./tslint.json --project . --exclude ./__tests__/* && echo TsLint test successfully passed.",
+    "test": "jest && npm run test-tsc && npm run test-tslint",
+    "test-tslint": "tslint --config ./tslint.json --project tsconfig.json && echo TsLint test successfully passed.",
     "test-tsc": "tsc -p . --noEmit",
     "test-watch": "jest --watchAll",
     "test-coverage": "npm test -- --coverage",
@@ -43,6 +43,7 @@
     "gulp": "github:gulpjs/gulp#4.0",
     "jest": "^20.0.4",
     "jest-enzyme": "^3.2.0",
+    "react-test-renderer": "^15.6.1",
     "simplr-mvdir": "0.0.1-beta.8",
     "sinon": "^2.3.4",
     "source-map-loader": "^0.2.1",

packages/simplr-forms-dom/src/abstractions/base-dom-field.tsx

@@ -1,5 +1,4 @@
 import { BaseField, BaseFieldState } from "simplr-forms";
-import { FieldProps } from "simplr-forms/contracts";
 import {
     DomFieldProps,
     DomFieldTemplateCallback,
@@ -8,7 +7,7 @@ import {
 } from "../contracts/field";
 import { FormProps } from "../contracts/form";
 
-export interface BaseDomFieldState extends BaseFieldState { }
+export type BaseDomFieldState = BaseFieldState;
 
 export abstract class BaseDomField<TProps extends DomFieldProps, TState extends BaseDomFieldState, TUnderlyingElement = any>
     extends BaseField<TProps, TState> {

packages/simplr-forms-dom/src/abstractions/base-form-button.tsx

@@ -3,7 +3,6 @@ import { recordify, TypedRecord } from "typed-immutable-record";
 import { Iterable } from "immutable";
 
 import { BaseContainer, BaseContainerProps } from "simplr-forms";
-import { FormError } from "simplr-forms/contracts";
 
 export interface BaseFormButtonProps extends BaseContainerProps, React.HTMLProps<HTMLButtonElement> {
     disableOnError?: boolean;
@@ -49,12 +48,10 @@ export abstract class BaseFormButton<TProps extends BaseFormButtonProps, TState
         // Type 'Readonly<TState>' cannot be converted to type 'Iterable<string, any>'.
         const stateIterable = this.state as any as Iterable<string, any>;
         if (!newStateRecord.equals(stateIterable)) {
-            this.setState((prevState) => {
-                // newStateRecord becomes an empty object after setState
-                // This happens because of an underlying Immutable.Record
-                // not enumerating properties in for..in
-                return newState;
-            });
+            // newStateRecord becomes an empty object after setState
+            // This happens because of an underlying Immutable.Record
+            // not enumerating properties in for..in
+            this.setState(() => newState);
         }
     }
 
@@ -120,5 +117,5 @@ export abstract class BaseFormButton<TProps extends BaseFormButtonProps, TState
         return className.length > 0 ? className : undefined;
     }
 
-    abstract render(): JSX.Element | null;
+    public abstract render(): JSX.Element | null;
 }

packages/simplr-forms-dom/src/components/checkbox.tsx

@@ -33,7 +33,7 @@ export class CheckBox extends BaseDomField<CheckBoxProps, BaseDomFieldState, HTM
         return event.currentTarget.checked;
     }
 
-    protected OnChangeHandler: React.ChangeEventHandler<HTMLInputElement> = (event) => {
+    protected OnChangeHandler: React.ChangeEventHandler<HTMLInputElement> = event => {
         this.OnValueChange(this.GetValueFromEvent(event));
 
         const newValue = this.FormStore.GetField(this.FieldId).Value;
@@ -58,7 +58,7 @@ export class CheckBox extends BaseDomField<CheckBoxProps, BaseDomFieldState, HTM
         return false;
     }
 
-    renderField(): JSX.Element | null {
+    public renderField(): JSX.Element {
         return <input
             ref={this.SetElementRef}
             type="checkbox"

packages/simplr-forms-dom/src/components/clear.tsx

@@ -1,7 +1,4 @@
 import * as React from "react";
-import { recordify, TypedRecord } from "typed-immutable-record";
-
-import { BaseContainer, BaseContainerProps } from "simplr-forms";
 
 import {
     BaseFormButton,
@@ -23,7 +20,7 @@ export class Clear extends BaseFormButton<ClearProps, BaseFormButtonStateRecord>
         }
     }
 
-    render(): JSX.Element | null {
+    public render(): JSX.Element {
         // TODO: Pass all other props.
         return <button
             type="button"