Commit 00c8afa
committed
perf(memoization,cacache): O(n) → O(1) LRU / regex compile in hot loops
Two independent hot-path wins:
**memoization.ts** — `memoize()` and `memoizeAsync()` previously
maintained a parallel `accessOrder: string[]` alongside the primary
`cache: Map`, and bumped recency on every cache hit via
`indexOf()` (O(n)) + `splice()` (O(n)). For a fully-populated cache
of size 1000, every hit walked up to 1000 entries and shifted the
tail. LRU eviction also did `accessOrder.shift()` which is O(n).
Replace with a Map-insertion-order idiom: `cache.delete(key)` +
`cache.set(key, entry)` moves an entry to the tail in O(1), and
`cache.keys().next().value` returns the oldest in O(1). The parallel
array is gone; every `cache` Map operation stays O(1). Same pattern
already used in `dlx/detect.ts` and `dlx/package.ts`.
memoizeAsync gains a small `bumpRecency()` helper to centralize the
delete-then-set idiom across the hit and stale-dedup branches.
**cacache.ts** — `clear()`'s wildcard branch streamed every cache
entry through `matchesPattern(key, pattern)`, which re-compiled the
regex on every key. For a wildcard clear across N entries that's N
redundant regex compiles. Refactor to `createPatternMatcher(pattern)`
which compiles once and closes over the regex; call sites hoist the
matcher out of the stream loop, dropping regex allocations from
O(N) to O(1). Non-wildcard patterns stay on the fast prefix path.
All 41 memoization tests + 29 cacache tests pass unchanged; full
suite 6327/6327 passing. No API surface changes.1 parent 1a882a5 commit 00c8afa
3 files changed
Lines changed: 106 additions & 79 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
8 | 60 | | |
9 | 61 | | |
10 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
44 | 50 | | |
45 | | - | |
46 | | - | |
| 51 | + | |
47 | 52 | | |
48 | | - | |
| 53 | + | |
49 | 54 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 55 | + | |
62 | 56 | | |
63 | | - | |
64 | 57 | | |
65 | | - | |
| 58 | + | |
| 59 | + | |
66 | 60 | | |
67 | 61 | | |
68 | 62 | | |
| |||
136 | 130 | | |
137 | 131 | | |
138 | 132 | | |
139 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
140 | 136 | | |
| 137 | + | |
141 | 138 | | |
142 | 139 | | |
143 | 140 | | |
144 | 141 | | |
145 | | - | |
| 142 | + | |
146 | 143 | | |
147 | 144 | | |
148 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
153 | 157 | | |
154 | | - | |
155 | 158 | | |
156 | 159 | | |
157 | 160 | | |
158 | 161 | | |
159 | | - | |
160 | 162 | | |
161 | 163 | | |
162 | 164 | | |
163 | | - | |
164 | | - | |
165 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
185 | | - | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
189 | 190 | | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
196 | 195 | | |
197 | 196 | | |
198 | 197 | | |
199 | 198 | | |
200 | | - | |
| 199 | + | |
201 | 200 | | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | 201 | | |
207 | 202 | | |
208 | | - | |
209 | 203 | | |
210 | 204 | | |
211 | 205 | | |
212 | | - | |
213 | 206 | | |
214 | 207 | | |
215 | 208 | | |
216 | 209 | | |
217 | 210 | | |
218 | 211 | | |
219 | | - | |
220 | 212 | | |
221 | 213 | | |
222 | 214 | | |
| |||
253 | 245 | | |
254 | 246 | | |
255 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
256 | 251 | | |
257 | | - | |
258 | 252 | | |
259 | 253 | | |
260 | 254 | | |
261 | 255 | | |
262 | | - | |
263 | 256 | | |
264 | 257 | | |
265 | 258 | | |
266 | | - | |
267 | | - | |
268 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
269 | 262 | | |
270 | 263 | | |
271 | 264 | | |
| |||
282 | 275 | | |
283 | 276 | | |
284 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | | - | |
292 | 291 | | |
293 | 292 | | |
294 | 293 | | |
295 | 294 | | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
| 295 | + | |
303 | 296 | | |
304 | 297 | | |
305 | 298 | | |
| |||
310 | 303 | | |
311 | 304 | | |
312 | 305 | | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
| 306 | + | |
318 | 307 | | |
319 | 308 | | |
320 | | - | |
| 309 | + | |
321 | 310 | | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | 311 | | |
327 | 312 | | |
328 | | - | |
329 | 313 | | |
330 | 314 | | |
331 | | - | |
| 315 | + | |
332 | 316 | | |
333 | 317 | | |
334 | 318 | | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
342 | 326 | | |
343 | 327 | | |
344 | 328 | | |
| |||
348 | 332 | | |
349 | 333 | | |
350 | 334 | | |
351 | | - | |
| 335 | + | |
352 | 336 | | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | 337 | | |
358 | 338 | | |
359 | 339 | | |
360 | 340 | | |
361 | 341 | | |
362 | 342 | | |
363 | | - | |
364 | 343 | | |
365 | 344 | | |
366 | 345 | | |
367 | 346 | | |
368 | 347 | | |
369 | 348 | | |
370 | | - | |
371 | 349 | | |
372 | 350 | | |
373 | 351 | | |
| |||
0 commit comments