Skip to content

Commit e60d115

Browse files
committed
fix(workflow): publish-script should be publish:ci
The Publish workflow referenced 'release:ci' but package.json defines 'publish:ci'. Every real release dispatch would have failed with "script not found" — flagged in docs/release.md as a hazard but never fixed until now. Aligns with fleet convention (socket-sdk-js and socket-registry both use 'publish:ci'). Updated docs/release.md to match the new workflow value and generalized the hazards note so it warns about "drift" in the generic sense instead of naming the old mismatch.
1 parent 48687d8 commit e60d115

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/provenance.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
debug: ${{ inputs.debug }}
3333
dist-tag: ${{ inputs.dist-tag }}
3434
package-name: '@socketregistry/packageurl-js'
35-
publish-script: 'release:ci'
35+
publish-script: 'publish:ci'
3636
setup-script: 'ci:validate'
3737
use-trusted-publishing: true
3838
secrets:

docs/release.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Three things happen, in order:
3636
┌───────────────────────────────────────────────────────────────┐
3737
│ 3. the workflow (calling the fleet's shared provenance.yml): │
3838
│ ci:validate → pnpm check + build + coverage │
39-
release:ci → npm publish --provenance │
39+
publish:ci → npm publish --provenance │
4040
│ Socket.dev → post-publish malware audit │
4141
│ Sigstore → attestation published │
4242
└───────────────────────────────────────────────────────────────┘
@@ -59,7 +59,7 @@ with:
5959
debug: ${{ inputs.debug }}
6060
dist-tag: ${{ inputs.dist-tag }}
6161
package-name: '@socketregistry/packageurl-js'
62-
publish-script: 'release:ci'
62+
publish-script: 'publish:ci'
6363
setup-script: 'ci:validate'
6464
use-trusted-publishing: true
6565
secrets:
@@ -76,7 +76,7 @@ Key choices:
7676
- **`setup-script: 'ci:validate'`** — runs `pnpm check` in a clean
7777
env before the publish starts. Publication aborts if any check
7878
fails.
79-
- **`publish-script: 'release:ci'`** — the npm script the workflow
79+
- **`publish-script: 'publish:ci'`** — the npm script the workflow
8080
invokes to actually publish. Wraps `npm publish --provenance`.
8181

8282
### The dist-tag input
@@ -250,11 +250,11 @@ consequences (integrity mismatches, dependency confusion risks).
250250
- **Publishing from a non-clean tree.** The workflow runs
251251
`ci:validate`, but if a bump commit bundles unrelated changes,
252252
those ship too. Keep bump commits single-purpose.
253-
- **`release:ci` vs `publish:ci` script name drift.** The workflow
254-
calls `release:ci`. Confirm `package.json` has that script name;
255-
otherwise the workflow falls over with "script not found." (If
256-
renamed, update either this file and the workflow, or the
257-
script, in the same PR.)
253+
- **`publish-script` drift.** The workflow calls the npm script
254+
whose name is in `publish-script` (currently `publish:ci`). If
255+
`package.json`'s script is ever renamed, update both the
256+
workflow input and this doc in the same PR — otherwise the
257+
workflow fails with "script not found."
258258
- **Trusted publisher misconfig.** If the npm-side trusted-publisher
259259
config for this repo is removed or the workflow file is renamed,
260260
publishes will fail with a 403. Check npm's trusted publisher

0 commit comments

Comments
 (0)