lint

Author: peter-rauscher

pyproject.toml

@@ -27,7 +27,7 @@ requests-aws4auth = "^1.3.1"
 ruff = "^0.9.4"
 debugpy = "^1.8.13"
 
-[tool.ruff]
+[tool.ruff.lint]
 select = [
   "E",   # pycodestyle error
   "W",   # pycodestyle warning
@@ -43,3 +43,4 @@ select = [
   "UP",  # pyupgrade  
   "S",   # bandit
 ]
+ignore = ["COM812"]

src/solesearch_api/models/sneaker.py

@@ -1,7 +1,6 @@
 from datetime import datetime
 from decimal import Decimal
 from functools import reduce
-from typing import Any
 
 from pydantic import computed_field
 from sqlalchemy import Index, UniqueConstraint

src/solesearch_api/routes/scrape.py

@@ -1,9 +1,11 @@
 from celery.result import AsyncResult
 from fastapi import APIRouter, HTTPException, Request
 
-from solesearch_api.tasks.scraping import adidas_new_releases_task
-from solesearch_api.tasks.scraping import nike_scraping_task
-from solesearch_api.tasks.scraping import nike_instock_scraping_task
+from solesearch_api.tasks.scraping import (
+    adidas_new_releases_task,
+    nike_instock_scraping_task,
+    nike_scraping_task,
+)
 
 router = APIRouter(
     prefix="/scrape",

src/solesearch_api/tasks/__init__.py

@@ -51,5 +51,5 @@ def init_beat(*args, **kwargs):
     },
 }
 
+import solesearch_api.tasks.alerting
 import solesearch_api.tasks.scraping
-import solesearch_api.tasks.alerting.healthcheck

src/solesearch_api/tasks/alerting/__init__.py

@@ -0,0 +1,2 @@
+# Import all tasks to ensure they are registered with Celery
+from solesearch_api.tasks.alerting.healthcheck import healthcheck

src/solesearch_api/tasks/alerting/healthcheck.py

@@ -1,12 +1,13 @@
 import logging
+
 import requests
 from requests_aws4auth import AWS4Auth
 
 from solesearch_api.config import (
     AWS_ACCESS_KEY_ID,
     AWS_HEALTHCHECK_URL,
-    AWS_SECRET_ACCESS_KEY,
     AWS_REGION,
+    AWS_SECRET_ACCESS_KEY,
     ENVIRONMENT,
 )
 from solesearch_api.tasks import app
@@ -24,11 +25,12 @@
 
 @app.task(name="solesearch_api.tasks.alerting.healthcheck")
 def healthcheck():
-    if not ENVIRONMENT == "production":
+    if ENVIRONMENT != "production":
         return
     response = requests.post(
         AWS_HEALTHCHECK_URL,
         json={"ping": True},
         auth=auth,
+        timeout=20,
     )
     response.raise_for_status()

src/solesearch_api/tasks/scraping/__init__.py

@@ -3,7 +3,7 @@
     adidas_new_releases_task,
 )
 from solesearch_api.tasks.scraping.retail.adidas.pdp import adidas_pdp_task
-from solesearch_api.tasks.scraping.retail.nike.new_releases import nike_scraping_task
 from solesearch_api.tasks.scraping.retail.nike.in_stock import (
     nike_instock_scraping_task,
 )
+from solesearch_api.tasks.scraping.retail.nike.new_releases import nike_scraping_task

src/solesearch_api/tasks/scraping/base.py

@@ -1,11 +1,11 @@
 import json
+import logging
 import os
 import random
 import time
 from datetime import datetime
 from typing import Callable
 
-import logging
 import requests
 from requests.adapters import HTTPAdapter
 from sqlmodel import Session

src/solesearch_api/tasks/scraping/retail/nike/new_releases.py

@@ -1,5 +1,4 @@
-import re
-from datetime import UTC, datetime
+from datetime import datetime
 from zoneinfo import ZoneInfo
 
 import logfire
@@ -9,7 +8,6 @@
     Image,
     Link,
     NikeLaunch,
-    Price,
     Sneaker,
     SneakerSize,
 )
@@ -289,23 +287,22 @@ def json_to_sneakers(self, json: dict) -> list[Sneaker]:
                 # First, check for 1st-level cards that are images and see if any productIds match
                 position = 0
                 for card in thread["cards"]:
-                    if card["subType"] == "image":
-                        if card.get("actions"):
-                            # if any action has a productId that matches the current productId, use this image
-                            for action in card["actions"]:
-                                if action["product"]["productId"] == product_id:
-                                    if card.get("imageId") and card.get("imageSlug"):
-                                        image_url = f"https://static.nike.com/a/images/{card['imageId']}/{card['imageSlug']}.jpg"
-                                    else:
-                                        image_url = card["defaultURL"]
-                                    sneaker_images.append(
-                                        Image(
-                                            platform=Platform.RETAIL,
-                                            position=position,
-                                            url=image_url,
-                                        ),
-                                    )
-                                    position += 1
+                    if card["subType"] == "image" and card.get("actions"):
+                        # if any action has a productId that matches the current productId, use this image
+                        for action in card["actions"]:
+                            if action["product"]["productId"] == product_id:
+                                if card.get("imageId") and card.get("imageSlug"):
+                                    image_url = f"https://static.nike.com/a/images/{card['imageId']}/{card['imageSlug']}.jpg"
+                                else:
+                                    image_url = card["defaultURL"]
+                                sneaker_images.append(
+                                    Image(
+                                        platform=Platform.RETAIL,
+                                        position=position,
+                                        url=image_url,
+                                    ),
+                                )
+                                position += 1
                 if not sneaker_images:
                     for index, image in enumerate(carousel["cards"]):
                         if image["subType"] == "image":

src/solesearch_api/utils/browser.py

@@ -10,7 +10,7 @@
 
 
 def get_random_user_agent():
-    return random.choice(USER_AGENTS)
+    return random.choice(USER_AGENTS)  # noqa: S311
 
 
 def get_default_browser_headers():