various feature toggle updates (#233)

Author: JoshuaEstes

src/SonsOfPHP/Component/FeatureToggle/Provider/InMemoryFeatureToggleProvider.php

@@ -15,8 +15,6 @@
  */
 final class InMemoryFeatureToggleProvider implements FeatureToggleProviderInterface
 {
-    public $feature;
-
     private array $features = [];
 
     /**
@@ -32,7 +30,7 @@ public function __construct(array $features = [])
     public function get(string $key): FeatureInterface
     {
         if ($this->has($key)) {
-            return $this->feature[$key];
+            return $this->features[$key];
         }
 
         throw new FeatureNotFoundException(sprintf('Feature "%s" not found', $key));

src/SonsOfPHP/Component/FeatureToggle/Tests/FeatureTest.php

@@ -11,6 +11,7 @@
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Context;
 use SonsOfPHP\Component\FeatureToggle\Feature;
+use SonsOfPHP\Contract\FeatureToggle\Exception\InvalidArgumentExceptionInterface;
 use SonsOfPHP\Contract\FeatureToggle\FeatureInterface;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
@@ -19,33 +20,37 @@
 #[UsesClass(Context::class)]
 final class FeatureTest extends TestCase
 {
+    private Feature $feature;
+
     private ToggleInterface&MockObject $toggle;
 
     protected function setUp(): void
     {
         $this->toggle = $this->createMock(ToggleInterface::class);
+
+        $this->feature = new Feature('key', $this->toggle);
     }
 
     public function testItHasTheCorrectInterface(): void
     {
-        $feature = new Feature('example', $this->toggle);
-
-        $this->assertInstanceOf(FeatureInterface::class, $feature);
+        $this->assertInstanceOf(FeatureInterface::class, $this->feature);
     }
 
-    public function testItReturnsTheCorrectKey(): void
+    public function testItsKeyIsInmutable(): void
     {
-        $feature = new Feature('example', $this->toggle);
-
-        $this->assertSame('example', $feature->getKey());
+        $this->assertSame('key', $this->feature->getKey());
     }
 
-    public function testIsEnabled(): void
+    public function testItsIsEnabledReturnsTrue(): void
     {
         $this->toggle->expects($this->once())->method('isEnabled')->willReturn(true);
 
-        $feature = new Feature('example', $this->toggle);
+        $this->assertTrue($this->feature->isEnabled(new Context()));
+    }
 
-        $this->assertTrue($feature->isEnabled(new Context()));
+    public function testItWillThrowExceptionForInvalidKey(): void
+    {
+        $this->expectException(InvalidArgumentExceptionInterface::class);
+        new Feature('test-key', $this->toggle);
     }
 }

src/SonsOfPHP/Component/FeatureToggle/Tests/Provider/InMemoryFeatureToggleProviderTest.php

@@ -6,26 +6,74 @@
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Group;
-use PHPUnit\Framework\Attributes\UsesClass;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use SonsOfPHP\Component\FeatureToggle\Feature;
 use SonsOfPHP\Component\FeatureToggle\Provider\InMemoryFeatureToggleProvider;
+use SonsOfPHP\Contract\FeatureToggle\Exception\FeatureAlreadyExistsExceptionInterface;
+use SonsOfPHP\Contract\FeatureToggle\Exception\FeatureNotFoundExceptionInterface;
+use SonsOfPHP\Contract\FeatureToggle\Exception\InvalidArgumentExceptionInterface;
+use SonsOfPHP\Contract\FeatureToggle\FeatureInterface;
 use SonsOfPHP\Contract\FeatureToggle\FeatureToggleProviderInterface;
 
 #[Group('feature-toggle')]
 #[CoversClass(InMemoryFeatureToggleProvider::class)]
-#[UsesClass(Feature::class)]
 final class InMemoryFeatureToggleProviderTest extends TestCase
 {
     private InMemoryFeatureToggleProvider $provider;
 
+    private FeatureInterface&MockObject $feature;
+
     protected function setUp(): void
     {
         $this->provider = new InMemoryFeatureToggleProvider();
+
+        $this->feature = $this->createMock(FeatureInterface::class);
+        $this->feature->method('getKey')->willReturn('test');
     }
 
     public function testItHasTheCorrectInterface(): void
     {
         $this->assertInstanceOf(FeatureToggleProviderInterface::class, $this->provider);
     }
+
+    public function testItsAddWillAddFeature(): void
+    {
+        $this->assertFalse($this->provider->has('test'));
+        $this->provider->add($this->feature);
+        $this->assertTrue($this->provider->has('test'));
+    }
+
+    public function testItsAddWillThrowExceptionIfAlreadyAdded(): void
+    {
+        $this->provider->add($this->feature);
+        $this->expectException(FeatureAlreadyExistsExceptionInterface::class);
+        $this->provider->add($this->feature);
+    }
+
+    public function testItsGetCanReturnCorrectFeature(): void
+    {
+        $this->provider->add($this->feature);
+        $this->assertSame($this->feature, $this->provider->get('test'));
+    }
+
+    public function testItsGetWillThrowExceptionIfFeatureNotFound(): void
+    {
+        $this->expectException(FeatureNotFoundExceptionInterface::class);
+        $this->provider->get('test');
+    }
+
+    public function testItsHasWillThrowExceptionWhenInvalidKeyIsPassed(): void
+    {
+        $this->expectException(InvalidArgumentExceptionInterface::class);
+        $this->provider->has('invalid-key');
+    }
+
+    public function testItsAllWillReturnFeaturesInCorrectFormat(): void
+    {
+        $this->provider->add($this->feature);
+
+        $features = iterator_to_array($this->provider->all());
+        $this->assertArrayHasKey('test', $features);
+        $this->assertSame($this->feature, $features['test']);
+    }
 }

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/AffirmativeToggleTest.php

@@ -5,12 +5,14 @@
 namespace SonsOfPHP\Component\FeatureToggle\Tests\Toggle;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Toggle\AffirmativeToggle;
 use SonsOfPHP\Component\FeatureToggle\Toggle\MockToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(AffirmativeToggle::class)]
 #[UsesClass(MockToggle::class)]
 final class AffirmativeToggleTest extends TestCase

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/AlwaysDisabledToggleTest.php

@@ -5,12 +5,14 @@
 namespace SonsOfPHP\Component\FeatureToggle\Tests\Toggle;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Context;
 use SonsOfPHP\Component\FeatureToggle\Toggle\AlwaysDisabledToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(AlwaysDisabledToggle::class)]
 #[UsesClass(Context::class)]
 final class AlwaysDisabledToggleTest extends TestCase

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/AlwaysEnabledToggleTest.php

@@ -5,12 +5,14 @@
 namespace SonsOfPHP\Component\FeatureToggle\Tests\Toggle;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Context;
 use SonsOfPHP\Component\FeatureToggle\Toggle\AlwaysEnabledToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(AlwaysEnabledToggle::class)]
 #[UsesClass(Context::class)]
 final class AlwaysEnabledToggleTest extends TestCase

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/ChainToggleTest.php

@@ -5,12 +5,14 @@
 namespace SonsOfPHP\Component\FeatureToggle\Tests\Toggle;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Toggle\ChainToggle;
 use SonsOfPHP\Component\FeatureToggle\Toggle\MockToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(ChainToggle::class)]
 #[UsesClass(MockToggle::class)]
 final class ChainToggleTest extends TestCase

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/DateRangeToggleTest.php

@@ -6,12 +6,14 @@
 
 use DateTimeImmutable;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Context;
 use SonsOfPHP\Component\FeatureToggle\Toggle\DateRangeToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(DateRangeToggle::class)]
 #[UsesClass(DateRangeToggle::class)]
 #[UsesClass(Context::class)]

src/SonsOfPHP/Component/FeatureToggle/Tests/Toggle/MockToggleTest.php

@@ -5,12 +5,14 @@
 namespace SonsOfPHP\Component\FeatureToggle\Tests\Toggle;
 
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\UsesClass;
 use PHPUnit\Framework\TestCase;
 use SonsOfPHP\Component\FeatureToggle\Context;
 use SonsOfPHP\Component\FeatureToggle\Toggle\MockToggle;
 use SonsOfPHP\Contract\FeatureToggle\ToggleInterface;
 
+#[Group('feature-toggle')]
 #[CoversClass(MockToggle::class)]
 #[UsesClass(Context::class)]
 final class MockToggleTest extends TestCase