Update DurationType to exclude seconds by default

Author: chapterjason

src/Form/DurationType.php

@@ -128,7 +128,7 @@ public function configureOptions(OptionsResolver $resolver): void
             'day' => false,
             'hour' => true,
             'minute' => true,
-            'second' => true,
+            'second' => false,
         ]);
 
         $resolver->setAllowedTypes('year', 'bool');

tests/Form/DurationTypeTest.php

@@ -19,19 +19,19 @@ public function testSubmitValidData(): void
         $form->submit([
             'hour' => '3',
             'minute' => '34',
-            'second' => '12',
         ]);
 
         // Assert
         $this->assertTrue($form->isSynchronized());
-        $this->assertEquals(new Second("12852"), $form->getData()->getValue());
+        $this->assertEquals(new Second("12840"), $form->getData()->getValue());
     }
 
     public function testConfigureAnotherUnit(): void
     {
         // Arrange
         $form = $this->factory->create(DurationType::class, null, [
             'month' => true,
+            'second' => true,
         ]);
 
         // Act
@@ -63,7 +63,7 @@ public function testSubmitNull(): void
     public function testWithPreData(): void
     {
         // Arrange
-        $form = $this->factory->create(DurationType::class, Duration::create(new Hour(3)));
+        $form = $this->factory->create(DurationType::class, Duration::create(new Hour(3.2)));
 
         // Act
         $view = $form->createView();
@@ -74,8 +74,8 @@ public function testWithPreData(): void
             'month' => null,
             'day' => null,
             'hour' => '3',
-            'minute' => '0',
-            'second' => '0',
+            'minute' => '12',
+            'second' => null,
         ], $view->vars['value']);
     }