Commit c50b9ac
committed
Update webhook test, added exception for this
This commit has two fixes:
a. The pull request hook parsing should work
test was failing, as it was not expecting
the number parameter in plugin_data->github->pull_request
We are parsing and sending the pull request
number in webhooks.js around line 128
Here, I expect that the source is correct and
the test needs to be updated.
b. The Step module requires the use of "this"
(https://www.npmjs.com/package/step)
However JSHint has a problem with that usage of this.
JSHint says "Possible strict violation" because we are using
this inside something that, as far as it can tell, is not a method.
That leads to a fail during npm test.
Since the source code must use the Step module,
hence added a jshint exception for W040.1 parent ddf1299 commit c50b9ac
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | 45 | | |
47 | 46 | | |
48 | 47 | | |
| |||
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
54 | | - | |
| 53 | + | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
0 commit comments