bump phpstan, fix analysis, drop symfony/process 3.4

Author: Josh-G

.github/workflows/main.yml

@@ -9,7 +9,7 @@ jobs:
       fail-fast: false
       matrix:
         php: [7.3, 7.4, "8.0", 8.1, 8.2]
-        symfony_process: [3.4, 4.0, 5.0, 6.0]
+        symfony_process: [4.0, 5.0, 6.0]
         exclude:
           - php: 7.3
             symfony_process: 6

Dockerfile

@@ -3,27 +3,24 @@ FROM php:$PHP_VERSION-cli-alpine
 
 RUN apk add git zip unzip autoconf make g++
 
-# apparently newer xdebug needs these now?
-RUN apk add --update linux-headers
-
-RUN if [ -z "${PHP_VERSION##7\.*}" ]; then \
-    pecl install xdebug-2.9.8 && docker-php-ext-enable xdebug; \
-else \
-    pecl install xdebug && docker-php-ext-enable xdebug; \
-fi;
-
 RUN curl -sS https://getcomposer.org/installer | php \
     && mv composer.phar /usr/local/bin/composer
 
 WORKDIR /package
 
-COPY composer.json ./
+RUN adduser -D -g '' dev
+
+RUN chown dev -R /package
+
+USER dev
+
+COPY --chown=dev composer.json ./
 
 ARG SYMFONY_PROCESS=5
 RUN composer require symfony/process ^$SYMFONY_PROCESS.0
 
 RUN composer install
 
-COPY . .
+COPY --chown=dev . .
 
 RUN composer test

composer.json

@@ -22,7 +22,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.0",
-        "phpstan/phpstan": "^0.12.83"
+        "phpstan/phpstan": "^1.9"
     },
     "scripts": {
         "test": [

src/Chrome.php

@@ -139,12 +139,12 @@ private function getCommandFlags(): array
             $opts[] = "--no-displayHeaderFooter";
         }
         if ($this->getHeader()) {
-            $headerFile = $this->getFileForString($this->getHeader() ?: '');
+            $headerFile = $this->getFileForString($this->getHeader());
             $opts[] = "--headerTemplate";
             $opts[] = $headerFile;
         }
         if ($this->getFooter()) {
-            $footerFile = $this->getFileForString($this->getFooter() ?: '');
+            $footerFile = $this->getFileForString($this->getFooter());
             $opts[] = "--footerTemplate";
             $opts[] = $footerFile;
         }