add 3-parameter setMargin calls

Author: Josh-G

src/AbstractPDF.php

@@ -116,21 +116,26 @@ public function setFormat(string $format): self
      * @return self
      */
     public function setMargin(
-        ?string $top = null,
+        ?string $top,
         ?string $right = null,
         ?string $bottom = null,
         ?string $left = null
     ): self {
-        if ($top !== null and $right === null and $bottom === null and $left === null) {
+        if (func_num_args() === 1) {
             $this->marginTop = $top;
             $this->marginRight = $top;
             $this->marginBottom = $top;
             $this->marginLeft = $top;
-        } elseif ($top !== null and $right !== null and $bottom === null and $left === null) {
+        } elseif (func_num_args() === 2) {
             $this->marginTop = $top;
             $this->marginRight = $right;
             $this->marginBottom = $top;
             $this->marginLeft = $right;
+        } elseif (func_num_args() === 3) {
+            $this->marginTop = $top;
+            $this->marginRight = $right;
+            $this->marginBottom = $bottom;
+            $this->marginLeft = $right;
         } else {
             $this->marginTop = $top;
             $this->marginRight = $right;

test/AbstractPDFTest.php

@@ -48,6 +48,12 @@ public function test_margin()
         $this->assertSame('30px', $mock->getMarginRight());
         $this->assertSame('30px', $mock->getMarginBottom());
         $this->assertSame('30px', $mock->getMarginLeft());
+
+        $mock->setMargin('1px', '2px', '3px');
+        $this->assertSame('1px', $mock->getMarginTop());
+        $this->assertSame('2px', $mock->getMarginRight());
+        $this->assertSame('3px', $mock->getMarginBottom());
+        $this->assertSame('2px', $mock->getMarginLeft());
     }
 
     public function test_waitUntil()

test/BrowserlessTest.php

@@ -320,7 +320,7 @@ public function test_margin()
     {
         $client = $this->getMockedClient();
 
-        $client->expects($this->exactly(5))
+        $client->expects($this->exactly(6))
             ->method('post')
             ->withConsecutive(
                 [
@@ -351,6 +351,18 @@ public function test_margin()
                         ])
                     )
                 ],
+                [
+                    $this->anything(),
+                    $this->hasKeyValue(
+                        ['json', 'options', 'margin'],
+                        $this->equalTo([
+                            'top' => '5px',
+                            'right' => '6px',
+                            'bottom' => '7px',
+                            'left' => '6px',
+                        ])
+                    )
+                ],
                 [
                     $this->anything(),
                     $this->hasKeyValue(
@@ -379,6 +391,9 @@ public function test_margin()
         $bl->setMargin('1px', '2px');
         $bl->renderContent('test');
 
+        $bl->setMargin('5px', '6px', '7px');
+        $bl->renderContent('test');
+
         $bl->setMargin('1', '2', '3', '4');
         $bl->renderContent('test');
 

test/ChromeTest.php

@@ -473,7 +473,7 @@ public function test_margins()
     {
         $pdf = $this->getMockedPDF();
 
-        $pdf->expects($this->exactly(5))
+        $pdf->expects($this->exactly(6))
             ->method('createProcess')
             ->withConsecutive(
                 [ $this->logicalNot($this->contains('--margin')) ],
@@ -495,6 +495,12 @@ public function test_margins()
                         $this->contains('1px,2px,1px,2px')
                     )
                 ],
+                [
+                    $this->logicalAnd(
+                        $this->contains('--margin'),
+                        $this->contains('5px,6px,7px,6px')
+                    )
+                ],
                 [ $this->logicalNot($this->contains('--margin')) ]
             )
             ->will($this->returnCallback(function () { return $this->getMockedProcess(); }));
@@ -510,6 +516,9 @@ public function test_margins()
         $pdf->setMargin('1px', '2px');
         $pdf->renderContent('test');
 
+        $pdf->setMargin('5px', '6px', '7px');
+        $pdf->renderContent('test');
+
         $pdf->setMargin(null);
         $pdf->renderContent('test');
     }