improve and test function validate_unique_names()

Author: douwe

R/guide.R

@@ -57,10 +57,15 @@ read_guide <- function(path, verify_hash = FALSE) {
 #' @noRd
 #'
 validate_unique_names <- function(names_vector, name_type) {
-  if (anyDuplicated(names_vector)) {
-    duplicates <- unique(names_vector[duplicated(names_vector)])
+  duplications <- duplicated(names_vector)
+  if (any(duplications)) {
+    duplicates <- glue::glue_collapse(
+      glue::double_quote(unique(names_vector[duplications])),
+      sep = ', ',
+      last = " and "
+    )
     rlang::abort(glue::glue(
-      "Duplicate keys in {name_type} names of the translations: {paste0(duplicates, collapse = ', ')}"
+      "Duplicate keys in {name_type} names of the translations: {duplicates}"
     ))
   }
 }

tests/testthat/test-guide.R

@@ -49,6 +49,17 @@ test_that("check_guide: guide without a .template location yields an error", {
   )
 })
 
+test_that("Function validate_unique_names works correctly", {
+  expect_error(
+    validate_unique_names(c("a", "b", "a"), "short"),
+    regexp = "Duplicate keys in short names"
+  )
+  expect_error(
+    validate_unique_names(c("a", "b", "a"), "long"),
+    regexp = "Duplicate keys in long names"
+  )
+})
+
 test_that("read_guide: duplicate long names in translations yield an error", {
   expect_error(
     read_guide(test_path(