Fixed a error, that occurred in the Classic mode during calling an embedded delegate, which does not return a result

Author: Taritsyn

src/MsieJavaScriptEngine/HostObject.cs

@@ -33,7 +33,8 @@ private object InvokeDelegate(Delegate del, object[] args)
 
 			object[] processedArgs = args;
 
-			if (_engineMode == JsEngineMode.Classic && processedArgs.Length > 0)
+			if (_engineMode == JsEngineMode.Classic && processedArgs.Length > 0
+				&& del.Method.ReturnType != typeof(void))
 			{
 				processedArgs = processedArgs.Skip(1).ToArray();
 			}

src/MsieJavaScriptEngine/MsieJavaScriptEngine.csproj

@@ -20,19 +20,7 @@
 		<RepositoryUrl>https://github.com/Taritsyn/MsieJavaScriptEngine</RepositoryUrl>
 		<RepositoryType>git</RepositoryType>
 		<PackageTags>JavaScript;ECMAScript;MSIE;IE;Edge;Chakra</PackageTags>
-		<PackageReleaseNotes>1. Format of the error messages was unified;
-2. Created a new exception classes: `JsCompilationException`, `JsEngineException`, `JsFatalException`, `JsInterruptedException`, `JsScriptException` and `JsUsageException`. These exceptions are responsible for handling errors, some of which were previously handled by the `JsRuntimeException` class;
-3. In the `JsException` class was added two new properties: `Category` and `Description`;
-4. From the `JsRuntimeException` class was removed one property - `ErrorCode`;
-5. In the `JsRuntimeException` class was added three new properties: `Type`, `DocumentName` and `CallStack`;
-6. `JsEngineLoadException` class now is inherited from the `JsEngineException` class;
-7. `Format` method of the `JsErrorHelpers` class was renamed to the `GenerateErrorDetails`;
-8. One part of the auxiliary code was removed, and other part moved to an external library - [AdvancedStringBuilder](https://github.com/Taritsyn/AdvancedStringBuilder);
-9. Added a ability to interrupt execution of the script;
-10. In JsRT modes added a ability to pre-compile scripts;
-11. In `MsieJsEngine` class was added `SupportsScriptPrecompilation` property and four new methods: `Interrupt`, `Precompile`, `PrecompileFile` and `PrecompileResource`;
-12. In JavaScript engine settings was added one new property - `MaxStackSize` (default `492` or `984` KB);
-13. Added support of .NET Standard 2.0 (only supported `ChakraIeJsRt` and `ChakraEdgeJsRt` modes).</PackageReleaseNotes>
+		<PackageReleaseNotes>Fixed a error, that occurred in the `Classic` mode during calling an embedded delegate, which does not return a result.</PackageReleaseNotes>
 		<NeutralLanguage>en-US</NeutralLanguage>
 		<PackageOutputPath>../../nuget</PackageOutputPath>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>

src/MsieJavaScriptEngine/readme.txt

@@ -21,32 +21,8 @@
    =============
    RELEASE NOTES
    =============
-   1.  Format of the error messages was unified;
-   2.  Created a new exception classes: `JsCompilationException`,
-       `JsEngineException`, `JsFatalException`, `JsInterruptedException`,
-       `JsScriptException` and `JsUsageException`. These exceptions are responsible
-       for handling errors, some of which were previously handled by the
-       `JsRuntimeException` class;
-   3.  In the `JsException` class was added two new properties: `Category` and
-       `Description`;
-   4.  From the `JsRuntimeException` class was removed one property - `ErrorCode`;
-   5.  In the `JsRuntimeException` class was added three new properties: `Type`,
-       `DocumentName` and `CallStack`;
-   6.  `JsEngineLoadException` class now is inherited from the `JsEngineException`
-       class;
-   7.  `Format` method of the `JsErrorHelpers` class was renamed to the
-       `GenerateErrorDetails`;
-   8.  One part of the auxiliary code was removed, and other part moved to an
-       external library - AdvancedStringBuilder;
-   9.  Added a ability to interrupt execution of the script;
-   10. In JsRT modes added a ability to pre-compile scripts;
-   11. In `MsieJsEngine` class was added `SupportsScriptPrecompilation` property
-       and four new methods: `Interrupt`, `Precompile`, `PrecompileFile` and
-       `PrecompileResource`;
-   12. In JavaScript engine settings was added one new property - `MaxStackSize`
-       (default `492` or `984` KB);
-   13. Added support of .NET Standard 2.0 (only supported `ChakraIeJsRt` and
-       `ChakraEdgeJsRt` modes).
+   Fixed a error, that occurred in the `Classic` mode during calling an embedded
+   delegate, which does not return a result.
 
    ============
    PROJECT SITE

test/MsieJavaScriptEngine.Test.Common/InteropTestsBase.cs

@@ -5,6 +5,7 @@
 #endif
 using System.IO;
 using System.Linq;
+using System.Text;
 
 using NUnit.Framework;
 
@@ -540,6 +541,52 @@ public virtual void EmbeddingOfInstanceOfDelegateWithTwoParametersIsCorrect()
 			Assert.AreEqual(targetOutput, output);
 		}
 
+		[Test]
+		public virtual void EmbeddingOfInstanceOfDelegateWithoutResultIsCorrect()
+		{
+			// Arrange
+			var logBuilder = new StringBuilder();
+			Action<string> log = (string value) =>
+			{
+				logBuilder.AppendLine(value);
+			};
+
+			const string input = @"(function(log, undefined) {
+	var num = 2, count = 0;
+
+	log('-= Start code execution =-');
+
+	while (num != Infinity) {
+		num = num * num;
+		count++;
+	}
+
+	log('-= End of code execution =-');
+
+	return count;
+}(log));";
+			const int targetOutput = 10;
+			string targetLogOutput = "-= Start code execution =-" + Environment.NewLine +
+				"-= End of code execution =-" + Environment.NewLine;
+
+			// Act
+			int output;
+			string logOutput;
+
+			using (var jsEngine = CreateJsEngine())
+			{
+				jsEngine.EmbedHostObject("log", log);
+				output = jsEngine.Evaluate<int>(input);
+
+				logOutput = logBuilder.ToString();
+				logBuilder.Clear();
+			}
+
+			// Assert
+			Assert.AreEqual(targetOutput, output);
+			Assert.AreEqual(targetLogOutput, logOutput);
+		}
+
 		#endregion
 
 		#region Integration