Fix exceptions in tests caused by improper bounds checking

Author: pascalecu

archive/c/c-plus-plus/insertion-sort.cpp

@@ -7,18 +7,18 @@ void insertSort(std::vector<int> &v)
 {
     int n = v.size();
     int i = 0, j = 0, temp = 0;
-    for (i = 1; i < n; i++)
+    for (int i = 1; i < n; i++)
     {
         int store = v[i];
-        j = i - 1;
-        while (store < v[j] && j >= 0)
+        int j = i - 1;
+        
+        while (j >= 0 && v[j] > store)
         {
             v[j + 1] = v[j];
             j--;
         }
         v[j + 1] = store;
     }
-    return;
 }
 
 int main(int argc, char *argv[])

archive/c/c-plus-plus/roman-numeral.cpp

@@ -3,7 +3,7 @@
 
 using namespace std;
 
-bool is_roman(char x)
+bool is_invalid_roman(char x)
 {
     return !(x == 'I'
              || x == 'V'
@@ -27,7 +27,7 @@ int main(int argc, char *argv[])
 
     for (char c : s)
     {
-        if (is_roman(c))
+        if (is_invalid_roman(c))
         {
             cerr << "Error: invalid string of roman numerals" << endl;
             exit(0);
@@ -47,7 +47,7 @@ int main(int argc, char *argv[])
 
     for (int i = s.size() - 1; i >= 0; i--)
     {
-        if (value[s[i]] > value[s[i - 1]] && i > 0)
+        if (i > 0 && value[s[i]] > value[s[i - 1]])
         {
             num += value[s[i]] - value[s[i - 1]];
             i--;